pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: didier <did447@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: buildfarm@coelho.net
Subject: Re: LLVM compile failing in seawasp
Date: Sun, 28 Jul 2019 09:54:05 -0400
Message-ID: <24644.1564322045@sss.pgh.pa.us> (raw)
In-Reply-To: <alpine.DEB.2.21.1907280935520.1292@lancre>
References: <20190606173216.GA6306@alvherre.pgsql>
	<CAJRYxuLbtcN+D+KrD6wui-rhXoo7XOungCB5vAech=R90LOTuA@mail.gmail.com>
	<5762.1559866377@sss.pgh.pa.us>
	<CA+hUKGJUGreiJART78O=pd4k9x0fZebL5BfGe8_mHBJe6Qd_WQ@mail.gmail.com>
	<alpine.DEB.2.21.1907270700360.21735@lancre>
	<CA+hUKGKxQLVQ+W6fcvN5jPyPNX+6CAXDy0_n+xvWPnMn73O+wg@mail.gmail.com>
	<CA+hUKG+vW2BHoJXJYhzBpzwC-pH854MguThsLewLcGh4pst0Jg@mail.gmail.com>
	<alpine.DEB.2.21.1907280935520.1292@lancre>

Fabien COELHO <coelho@cri.ensmp.fr> writes:
> Otherwise, why not simply move llvm C++ includes *before* postgres 
> includes?

We've been burnt in the past by putting other headers before postgres.h.
(A typical issue is that the interpretation of <stdio.h> varies depending
on _LARGE_FILES or a similar macro, so you get problems if something
causes that to be included before pg_config.h has set that macro.)
Maybe none of the platforms where that's an issue have C++, but that
doesn't seem like a great assumption.

> They should be fully independent anyway, so the order should 
> not matter?

On what grounds do you claim that's true anywhere, let alone
everywhere?

			regards, tom lane





view thread (17+ messages)  latest in thread

Message-ID: <24644.1564322045@sss.pgh.pa.us>
Permalink:  ../24644.1564322045@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/24644.1564322045@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, coelho@cri.ensmp.fr, thomas.munro@gmail.com, did447@gmail.com, alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org, buildfarm@coelho.net
  Subject: Re: LLVM compile failing in seawasp
  In-Reply-To: <24644.1564322045@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox