pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: John Naylor <jcnaylor@gmail.com>
Cc: Stas Kelvich <s.kelvich@postgrespro.ru>
Cc: Andreas Karlsson <andreas@proxel.se>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: David Fetter <david@fetter.org>
Subject: Re: unused_oids script is broken with bsd sed
Date: Thu, 03 May 2018 22:42:41 -0400
Message-ID: <24838.1525401761@sss.pgh.pa.us> (raw)
In-Reply-To: <26d649cf-e3e6-2709-3190-b431930c1127@2ndquadrant.com>
References: <37D774E4-FE1F-437E-B3D2-593F314B7505@postgrespro.ru>
	<34a54c54-9132-1254-2bc3-d3489fb79728@2ndQuadrant.com>
	<4473.1524665917@sss.pgh.pa.us>
	<4DE444D1-DDE9-460F-AC2F-EB1B73D94A2D@postgrespro.ru>
	<CAJVSVGU2w6rvTXghDe7-Y3x9Ca0833VmnC3HpaYKGLw4xznpJA@mail.gmail.com>
	<26728623-7783-4103-9BED-08D443C1729F@postgrespro.ru>
	<CAJVSVGU0cPPwMhCfVz5PvpTDrjZzeT=0QHUhMbg=MjaMO_Gr+A@mail.gmail.com>
	<19973.1524686883@sss.pgh.pa.us>
	<CAJVSVGVrzzxzVkqYb-=UyqAJRVn1rCx8a2pAYXPLw+6JBg4EZA@mail.gmail.com>
	<31238.1524756550@sss.pgh.pa.us>
	<CA+Tgmobds-8ed3L6f4=Er0TBmCAM4f5c0qxEuQRtQhUWxh9AVA@mail.gmail.com>
	<16925.1525376229@sss.pgh.pa.us>
	<26d649cf-e3e6-2709-3190-b431930c1127@2ndquadrant.com>

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 5/3/18 15:37, Tom Lane wrote:
>> I took a quick look into this.  It's very easy to do so far as the Perl
>> code is concerned:

> I think in order to introduce warts like that, we have to have really
> great savings.  I haven't seen any actual analysis what the current
> problem is, other than one person expression a suspicion.

Well, the work's already done, and personally I think the code is
cleaner after 9bf28f96c and bad51a49a regardless of whether there's any
performance benefit.  You could call 1f1cd9b5d a wart if you wanted.
But we've done largely the same thing to pgindent, for one, in the past
year or so, and I find that to be a usability improvement, independently
of whether there's any build performance win.  My editor gets cranky
when files change under it for no reason.

			regards, tom lane




view thread (27+ messages)  latest in thread

Message-ID: <24838.1525401761@sss.pgh.pa.us>
Permalink:  ../24838.1525401761@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/24838.1525401761@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, robertmhaas@gmail.com, jcnaylor@gmail.com, s.kelvich@postgrespro.ru, andreas@proxel.se, andrew.dunstan@2ndquadrant.com, david@fetter.org
  Subject: Re: unused_oids script is broken with bsd sed
  In-Reply-To: <24838.1525401761@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox