From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Count output lines automatically in psql/help.c
Date: Fri, 10 Jun 2022 07:50:37 -0400
Message-ID: <2490638.1654861837@sss.pgh.pa.us> (raw)
In-Reply-To: <b0957499-7e28-9038-71c5-4f4c270a5cb6@enterprisedb.com>
References: <365160.1654289490@sss.pgh.pa.us>
<b0957499-7e28-9038-71c5-4f4c270a5cb6@enterprisedb.com>
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> I wonder whether this mix of HELP0 and HELP is necessary. The original
> code didn't care about calling fprintf even if there are no
> substitutions. I think this could lead to misalignment errors. I
> vaguely recall we once had mixes of fprintf and fputs and got rid of
> them for this reason.
In the committed patch, I changed HELP to HELPN exactly so that
the strings would still line up.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Count output lines automatically in psql/help.c
In-Reply-To: <2490638.1654861837@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox