From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: v16dev: TRAP: failed Assert("size > SizeOfXLogRecord"), File: "xlog.c", Line: 1055, PID: 13564
Date: Mon, 17 Apr 2023 14:26:22 -0400
Message-ID: <2496923.1681755982@sss.pgh.pa.us> (raw)
In-Reply-To: <20230417180009.akas7axm6vn5lxma@awork3.anarazel.de>
References: <ZD1daibg4RF50IOj@telsasoft.com>
<CAEze2Wg+Pbec3jaaUSF8E6Piy=bq=gXkFCFyaYwFDYTDjCMSvg@mail.gmail.com>
<2444561.1681748021@sss.pgh.pa.us>
<2454846.1681753830@sss.pgh.pa.us>
<20230417180009.akas7axm6vn5lxma@awork3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2023-04-17 13:50:30 -0400, Tom Lane wrote:
>> So previously, log_newpage_range could only have failed in very
>> unlikely circumstances, whereas now it's not hard to hit when
>> committing a table creation. I wonder what other bugs may be
>> lurking.
> Oh, interesting. We haven't initialized the extra pages added by
> RelationAddExtraBlocks() (in <= 15) for quite a while now, so I'm a bit
> surprised it causes more issues for the VM / FSM. I guess it's that it's quite
> common in real workloads to contend on the extension lock and add extra
> blocks, but not in simple single-threaded tests?
I haven't tried hard to run it to ground, but maybe log_newpage_range
isn't used in that code path? Seems like we'd have detected this
before now if the case were reachable without any crash involved.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, boekewurm+postgres@gmail.com, pryzby@telsasoft.com
Subject: Re: v16dev: TRAP: failed Assert("size > SizeOfXLogRecord"), File: "xlog.c", Line: 1055, PID: 13564
In-Reply-To: <2496923.1681755982@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox