From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>
Cc: pgsql-hackers@lists.postgresql.org, Chantal Keller <chantal.keller@universite-paris-saclay.fr>
Subject: Re: Improving EXPLAIN's display of SubPlan nodes
Date: Fri, 15 Mar 2024 10:58:25 -0400
Message-ID: <2506269.1710514705@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEZATCUQB3ybgBxEHXq28ihMS3+Bq-Gy8RraJpKGmVpjES6E3A@mail.gmail.com>
References: <2838538.1705692747@sss.pgh.pa.us>
<CAJ7c6TMApZ62NOOk73_BmKkKtdhV+i=tyvXR52DAB-YVuFANDA@mail.gmail.com>
<3791430.1705943243@sss.pgh.pa.us>
<3831858.1705959108@sss.pgh.pa.us>
<3511300.1708112330@sss.pgh.pa.us>
<CAEZATCUQB3ybgBxEHXq28ihMS3+Bq-Gy8RraJpKGmVpjES6E3A@mail.gmail.com>
Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> One thing that concerns me about making even greater use of "$n" is
> the potential for confusion with generic plan parameters.
True.
> Another possibility is to put the SubPlan and InitPlan names inline,
> rather than outputting "FROM SubPlan ...". I had a go at hacking that
> up and this was the result:
> Output: (($3 = (InitPlan 1).$0) AND ($4 = (InitPlan 1).$1) AND
> ((($1 = (SubPlan 2).$3) AND ($2 = (SubPlan 2).$4))))
Hmm. I guess what bothers me about that is that it could be read to
suggest that the initplan or subplan is evaluated again for each
output parameter. Perhaps it'll be sufficiently clear as long as
we keep the labeling
> InitPlan 1 (returns $0,$1)
> SubPlan 2 (returns $3,$4)
but I'm not sure. Anybody else have an opinion?
(I didn't read your changes to the code yet --- I think at this
point we can just debate proposed output without worrying about
how to implement it.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, dean.a.rasheed@gmail.com, aleksander@timescale.com, chantal.keller@universite-paris-saclay.fr
Subject: Re: Improving EXPLAIN's display of SubPlan nodes
In-Reply-To: <2506269.1710514705@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox