public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Thomas Munro <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Noah Misch <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set
Date: Sun, 13 Feb 2022 00:13:39 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+hUKGJDZt0MRhVSaaO5DX8KLjWf9RPD4YcsnfTSRcRjzCoY1g@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<20220115055239.6i5mp7ujtcpto2mg@jrouhaud>
	<YeYj4DU5qY/[email protected]>
	<[email protected]>
	<CA+hUKGJDZt0MRhVSaaO5DX8KLjWf9RPD4YcsnfTSRcRjzCoY1g@mail.gmail.com>

Thomas Munro <[email protected]> writes:
> I thought it was a goal that VPATH builds shouldn't pollute the source
> tree, but the Make macro prove_check is explicitly doing so by
> default.  Perhaps *that* should be fixed?

Indeed.  That seems broken by definition.

More generally, I thought we'd established a convention that
all files made by TAP tests should be put inside the tmp_check
directory, to simplify cleanup and .gitignore rules.  But in
a VPATH build, tmp_check ought to live in the build tree.

			regards, tom lane

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox