pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Making tab-complete.c easier to maintain
Date: Sat, 19 Dec 2015 10:38:55 -0500
Message-ID: <2547.1450539535@sss.pgh.pa.us> (raw)
In-Reply-To: <CAB7nPqS0-TjcwUWM4R+-77aCrAz9B6a+S_d973CeJvfLm7r-Tg@mail.gmail.com>
References: <CAB7nPqQ-=c0P7A1cWAo7ONNEPfq4+aNpX86a+oHKS4bcGs2C6Q@mail.gmail.com>
	<CAEepm=1x-inE_3Hsa07Wp5zDg2puGR1TdJsstgm0=ATXpxur=Q@mail.gmail.com>
	<CAB7nPqSggjPA8U1WV7ivW44xzboC8pci_Etmffr+ZEzxSX_ahA@mail.gmail.com>
	<20151217.150633.216859242.horiguchi.kyotaro@lab.ntt.co.jp>
	<CAB7nPqS=UHm2QyJtx+kyyHb4WH09vK3NVUqJVFBotQAQx5hD4g@mail.gmail.com>
	<CAEepm=2vMAESiiind-jbQK-sAibLr1440E8pj_KmWYO8XBtiRA@mail.gmail.com>
	<1851.1450471370@sss.pgh.pa.us>
	<CAB7nPqS0-TjcwUWM4R+-77aCrAz9B6a+S_d973CeJvfLm7r-Tg@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Michael Paquier <michael.paquier@gmail.com> writes:
> On Sat, Dec 19, 2015 at 5:42 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> 2. Why does MatchAnyExcept use "'" as the inversion flag, rather than
>> say "!" or "~" ?  Seems pretty random.

> Actually, "'" is not that much a good idea, no? There could be single
> quotes in queries so there is a risk of interfering with the
> completion... What do you think would be good candidates? "?", "!",
> "#" or "&"?

We don't care whether the character appears in queries; it only matters
that it not be something we'd need to use in patterns.  My inclination
is to use "!".

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (86+ messages)  latest in thread

Message-ID: <2547.1450539535@sss.pgh.pa.us>
Permalink:  ../2547.1450539535@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2547.1450539535@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael.paquier@gmail.com, thomas.munro@enterprisedb.com, horiguchi.kyotaro@lab.ntt.co.jp, alvherre@2ndquadrant.com, jeff.janes@gmail.com
  Subject: Re: Making tab-complete.c easier to maintain
  In-Reply-To: <2547.1450539535@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox