From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: meson: Add support for building with precompiled headers
Date: Wed, 05 Oct 2022 16:09:14 -0400
Message-ID: <2550386.1665000554@sss.pgh.pa.us> (raw)
In-Reply-To: <20221005190829.lda7ttalh4mzrvf4@awork3.anarazel.de>
References: <20221005190829.lda7ttalh4mzrvf4@awork3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> When using precompiled headers we cannot override macros in system headers
> from within .c files, as headers are already processed before the #define in
> the C file is reached.
> A few files #define FD_SETSIZE 1024 on windows, as the default is only 64. I
> am hesitant to change FD_SETSIZE globally on windows, due to
> src/backend/port/win32/socket.c using it to size on-stack arrays. Instead add
> -DFD_SETSIZE=1024 when building the specific targets needing it.
Color me confused, but how does it work to #define that from the command
line if it can't be overridden from within the program?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, thomas.munro@gmail.com, pryzby@telsasoft.com, michael.paquier@gmail.com, peter.eisentraut@enterprisedb.com
Subject: Re: meson: Add support for building with precompiled headers
In-Reply-To: <2550386.1665000554@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox