pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.
Date: Wed, 06 Sep 2017 12:16:12 -0400
Message-ID: <2597.1504714572@sss.pgh.pa.us> (raw)
In-Reply-To: <CANP8+jJvqSFYFyWnhOWVTbT=kv3NmV7viywe11PEauKoLF+ueg@mail.gmail.com>
References: <E1dpFCX-0004YD-E7@gemulon.postgresql.org>
	<CANP8+j+WC3zXTJrMQgfX1_TB23FmWzbiN71yWThb0N4gdvBgZQ@mail.gmail.com>
	<2774.1504628172@sss.pgh.pa.us>
	<CA+TgmoZpe2YJdFLFH6YSka5TVX4VcsmT05cEXWOHxJ2wzCBE2w@mail.gmail.com>
	<4782.1504630716@sss.pgh.pa.us>
	<CANP8+jLGoZKRA-HT2yqfg4YJiPsJ+qe0aKTpGbNsntbz-396WQ@mail.gmail.com>
	<alpine.DEB.2.20.1709052051590.17848@lancre>
	<CANP8+jLauL-q4=jynt=y8NpL7JXM1hjtywqLn5ha-cxLEqgjNA@mail.gmail.com>
	<18953.1504705115@sss.pgh.pa.us>
	<CANP8+jJvqSFYFyWnhOWVTbT=kv3NmV7viywe11PEauKoLF+ueg@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Simon Riggs <simon@2ndquadrant.com> writes:
> * Clarification that this will work for current AND past server versions

The short answer is it works.  I do not think we need a longer answer.

(The existing comment in libpq says that the "select version()" method
works in any server version that supports protocol v2, which means that
we will derive a correct server version ID for any server that modern
libpq is capable of connecting to at all.  I've not gone back to re-verify
what I wrote in 2003, but I see no reason to doubt it.  We'd have been
considerably more fussed about whether PQserverVersion worked correctly
for ancient server versions back then than we need be today.)

> * Clarification to avoid confusion between VERSION and SERVER_VERSION

In what way are these variables not adequately specified already?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (18+ messages)  latest in thread

Message-ID: <2597.1504714572@sss.pgh.pa.us>
Permalink:  ../2597.1504714572@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2597.1504714572@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, simon@2ndquadrant.com, coelho@cri.ensmp.fr, robertmhaas@gmail.com
  Subject: Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.
  In-Reply-To: <2597.1504714572@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox