pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jonathan S. Katz <jkatz@postgresql.org>
To: Amit Langote <amitlangote09@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: John Naylor <john.naylor@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size
Date: Thu, 11 Aug 2022 13:08:27 -0400
Message-ID: <25fc391a-1197-cfbf-cf4a-bce4c03e7fbf@postgresql.org> (raw)
In-Reply-To: <CA+HiwqHNcXW00xKeoVxbLURXLDXxYzw7FVgob2wyT8moXxOkJQ@mail.gmail.com>
References: <CA+HiwqFyNvVYSegZw5pWTSAi1EtZLBtAexP2APqgOOcGLn_31g@mail.gmail.com>
	<CA+HiwqEp=vF=0=tUPYz2N3OOp+19CgCrNBgLUUK7SWec_YZ5UQ@mail.gmail.com>
	<20220802003947.x2ezq7u7pkmxt6ie@awork3.anarazel.de>
	<CA+HiwqHU+wWGNjzk=5eV15Nth3jySbQeeUFnVfbZ1F3M6QUjDA@mail.gmail.com>
	<20220802150022.jqomxwum5eazybfv@awork3.anarazel.de>
	<CA+HiwqEe3n-v86zy4gL2g+BWZDxwEtVeGX8YuOqRh8y7R8QPPw@mail.gmail.com>
	<20220805203656.mdgmajvsahi5srcy@awork3.anarazel.de>
	<787cef45-15de-8f1d-ed58-a1c1435bfc0e@postgresql.org>
	<32d4a1e4-d218-b129-205e-e123ebaef6b8@dunslane.net>
	<4b02e8a0-2541-a739-d1e7-6cdd29239b24@postgresql.org>
	<20220809185725.t477tp54v3qv4uyi@awork3.anarazel.de>
	<CA+HiwqHNcXW00xKeoVxbLURXLDXxYzw7FVgob2wyT8moXxOkJQ@mail.gmail.com>

On 8/10/22 9:27 AM, Amit Langote wrote:
> On Wed, Aug 10, 2022 at 3:57 AM Andres Freund <andres@anarazel.de> wrote:
>> One way this code could be drastically simplified is to force all
>> type-coercions to go through the "io coercion" path, which could be
>> implemented as a single execution step (which thus could trivially
>> start/finish a subtransaction) and would remove a lot of the complicated code
>> around coercions.
> 
> Could you please clarify how you think we might do the io coercion
> wrapped with a subtransaction all as a single execution step?  I
> would've thought that we couldn't do the sub-transaction without
> leaving ExecInterpExpr() anyway, so maybe you meant the io coercion
> itself was done using some code outside ExecInterpExpr()?
> 
> The current JsonExpr code does it by recursively calling
> ExecInterpExpr() using the nested ExprState expressly for the
> coercion.

With RMT hat on, Andres do you have any thoughts on this?

Thanks,

Jonathan


Attachments:

  OpenPGP_signature (application/pgp-signature, 839B) download

view thread (75+ messages)  latest in thread

Message-ID: <25fc391a-1197-cfbf-cf4a-bce4c03e7fbf@postgresql.org>
Permalink:  ../25fc391a-1197-cfbf-cf4a-bce4c03e7fbf@postgresql.org/
Also on:    postgresql.org/message-id/25fc391a-1197-cfbf-cf4a-bce4c03e7fbf@postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: jkatz@postgresql.org, amitlangote09@gmail.com, andres@anarazel.de, andrew@dunslane.net, dgrowleyml@gmail.com, alvherre@alvh.no-ip.org, michael@paquier.xyz, john.naylor@enterprisedb.com, tgl@sss.pgh.pa.us, pg@bowt.ie, n.gluhov@postgrespro.ru
  Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size
  In-Reply-To: <25fc391a-1197-cfbf-cf4a-bce4c03e7fbf@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox