pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: jesper.pedersen@redhat.com, Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Oskari Saarenmaa <os@ohmu.fi>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Tobias Oberstein <tobias.oberstein@gmail.com>
Subject: Re: pread() and pwrite()
Date: Wed, 07 Nov 2018 09:30:37 -0500
Message-ID: <26123.1541601037@sss.pgh.pa.us> (raw)
In-Reply-To: <4ab64856-6822-ec37-934f-baab06413233@2ndQuadrant.com>
References: <20181105155918.jg36uj4rtnxwqtzt@alvherre.pgsql>
	<1791.1541438632@sss.pgh.pa.us>
	<CAEepm=1GmuQ---ZDmmDzU6uS0QF==PeD1N-XLY7pSfndxTpnfQ@mail.gmail.com>
	<856530e2-260d-1d61-ec18-595778868a1b@redhat.com>
	<CAEepm=0+GizsKRRd=7wrL0n8VMKadR0=o99VWiXD58oJyJOUCQ@mail.gmail.com>
	<cb062f4d-55b8-28be-b55f-2e593a3b3755@redhat.com>
	<4ab64856-6822-ec37-934f-baab06413233@2ndQuadrant.com>

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 11/7/18 7:26 AM, Jesper Pedersen wrote:
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2018-11-07%2001%3A01%3A01

> And lousyjack, which uses a slightly different way of calling valgrind, 
> and thus got past initdb, found a bunch more:
> <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-11-07%2001%3A33%3A01;

I'm confused by this.  Surely the pwrite-based code is writing exactly the
same data as before.  Do we have to conclude that valgrind is complaining
about passing uninitialized data to pwrite() when it did not complain
about exactly the same thing for write()?

[ looks ... ]  No, what we have to conclude is that the write-related
suppressions in src/tools/valgrind.supp need to be replaced or augmented
with pwrite-related ones.

			regards, tom lane




view thread (41+ messages)  latest in thread

Message-ID: <26123.1541601037@sss.pgh.pa.us>
Permalink:  ../26123.1541601037@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/26123.1541601037@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, thomas.munro@enterprisedb.com, alvherre@2ndquadrant.com, magnus@hagander.net, os@ohmu.fi, tobias.oberstein@gmail.com
  Subject: Re: pread() and pwrite()
  In-Reply-To: <26123.1541601037@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox