public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Andres Freund <[email protected]>
Cc: [email protected]
Subject: Re: [RFC] building postgres with meson -v8
Date: Tue, 24 May 2022 20:08:26 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 18.05.22 21:48, Andres Freund wrote:
> - CONFIGURE_ARGS - empty in meson, not clear what to fill it with

Ok to leave empty for now.

> - GETTIMEOFDAY_1ARG - test doesn't exist - I suspect it might not be necessary

Might be obsolete, consider removing.

> - PACKAGE_STRING, PACKAGE_TARNAME - unclear if they should be implemented?

leave out for now

> - AC_APPLE_UNIVERSAL_BUILD logic - which I don't think we need?

no

> - "missing" a bunch of defines that don't appear to be referenced:

Yeah, looks like these are implicitly defined by some autoconf check but 
then the result is only used within configure.ac itself, so isn't needed 
afterwards.

> - meson additional defines, seems harmless:
>    HAVE_GETTIMEOFDAY - only defined on windows rn
>    HAVE_SHM_UNLINK
>    HAVE_SSL_NEW
>    HAVE_STRTOQ
>    HAVE_STRTOUQ
>    HAVE_CRYPTO_NEW_EX_DATA

Yeah, that's the opposite of the previous.

I don't see any other issues in pg_config.h either.  Obviously, some 
niche platforms might uncover some issues, but it looks good for now.

view thread (46+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [RFC] building postgres with meson -v8
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox