pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_settings.pending_restart not set when line removed
Date: Tue, 27 Jul 2021 09:57:52 -0400
Message-ID: <263488.1627394272@sss.pgh.pa.us> (raw)
In-Reply-To: <202107262302.xsfdfc5sb7sh@alvherre.pgsql>
References: <202107262302.xsfdfc5sb7sh@alvherre.pgsql>

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> You could argue that this is *weird* (why does reading pg_file_settings
> set a flag in global state?) ... but that weirdness is not something
> this patch is introducing.

Ugh.  I think this patch is likely to create more problems than it fixes.
We should be looking to get rid of that flag, not make its behavior even
more complex.

			regards, tom lane





view thread (8+ messages)  latest in thread

Message-ID: <263488.1627394272@sss.pgh.pa.us>
Permalink:  ../263488.1627394272@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/263488.1627394272@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: pg_settings.pending_restart not set when line removed
  In-Reply-To: <263488.1627394272@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox