From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Ian Barwick <ian.barwick@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: PG12, PGXS and linking pgfeutils
Date: Thu, 09 May 2019 13:20:53 -0400
Message-ID: <26438.1557422453@sss.pgh.pa.us> (raw)
In-Reply-To: <18444.1557236767@sss.pgh.pa.us>
References: <a912ffff-f6e4-778a-c86a-cf5c47a12933@2ndquadrant.com>
<18444.1557236767@sss.pgh.pa.us>
I wrote:
> Ian Barwick <ian.barwick@2ndquadrant.com> writes:
>> Commit cc8d4151 [*] introduced a dependency between some functions in
>> libpgcommon and libpgfeutils,
> This seems rather seriously broken. I do not think the answer is to
> create a global dependency on libpgfeutils.
Or, to be clearer: fe_utils has had dependencies on libpgcommon since
its inception. What we are seeing here is that libpgcommon has now
grown some dependencies on libpgfeutils. That can't be allowed to
stand. We'd be better off giving up on the separation between those
libraries than having circular dependencies between them.
I'm not especially on board with the idea of moving FE-specific error
handling code into libpgcommon, as that breaks the concept that
src/common/ is broadly for code that can work in either frontend or
backend contexts. However, we already have a few violations of that
rule: common/Makefile already has
# A few files are currently only built for frontend, not server
OBJS_FRONTEND = $(OBJS_COMMON) fe_memutils.o file_utils.o restricted_token.o
So maybe the answer is to move these logging support functions into
src/common, in a file that's only built for frontend.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, ian.barwick@2ndquadrant.com
Subject: Re: PG12, PGXS and linking pgfeutils
In-Reply-To: <26438.1557422453@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox