public inbox for [email protected]  
help / color / mirror / Atom feed
From: Fujii Masao <[email protected]>
To: Jelte Fennema-Nio <[email protected]>
To: David Rowley <[email protected]>
Cc: Michael Christofides <[email protected]>
Cc: Guillaume Lelarge <[email protected]>
Cc: Greg Sabino Mullane <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Nikolay Samokhvalov <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE
Date: Fri, 30 May 2025 23:36:40 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CANNMO++9W_UA8PB9AkDRF3JBv4K7K1FnisrXTjicL+WZhwUJzw@mail.gmail.com>
	<CAKAnmmLOkvJ85MGyouFBr2tS+0TSZ87=t=8iaZKU25WG98nZaw@mail.gmail.com>
	<CAECtzeUwpK5gNWQqoK4ZjwXANtdE2fWirJyaBDqkytPzfWZqzg@mail.gmail.com>
	<CAKAnmm+QQP-dTkjsDVbEcphrdXqCTq-ALTCMUwPaYWZmqUp=NQ@mail.gmail.com>
	<CAECtzeVkkmvmHWVOTzwpX_GX+k4h7EWAyfERqes9C0z4pzMN2A@mail.gmail.com>
	<CAApHDvpj0Cj6Z8VnDN5htzF24b4_hKL+1_n=HOehLHkBK_E_TQ@mail.gmail.com>
	<CAECtzeUWiA+FNq0qGp94Ez4UAwbEZyB7avTqKDs6wkPhU56mpw@mail.gmail.com>
	<CAApHDvqjmr=CZ2M57eErxn2Ubcb0d2EmppZhTj8k==Ud_eRfoQ@mail.gmail.com>
	<CAApHDvqLdzgz77JsE-yTki3w9UiKQ-uTMLRctazcu+99-ips3g@mail.gmail.com>
	<CAApHDvqJcsNsmU4d8q24qZy4Rm0OzxQ4jDRRNBV1P6xrYWwxCQ@mail.gmail.com>
	<CAFwT4nABCCOs242KoOToR54NVhDsHC73dm50qBWBwpt9unA3wg@mail.gmail.com>
	<[email protected]>
	<CAApHDvpqjJqXq2eBXzCqeoAyVANnVg7brrkRiQMENBo8tf44_Q@mail.gmail.com>
	<[email protected]>



On 2025/05/30 21:43, Jelte Fennema-Nio wrote:
> On Fri May 30, 2025 at 1:55 PM CEST, David Rowley wrote:
>> By my count, those who think we should change log_buffers to true are:
>> Robert [1], Michael Christofides [2], Fujii [3].
> 
> +1 for me on changing the default. It just seems confusing to have
> different defaults for auto_explain and EXPLAIN. I'd even vote for
> making that change still for PG18, since this feels like an oversight
> that the defaults were not kept aligned.
> 
> 
>> log_min_duration = 0, log_buffers = off: 11231 tps
>> log_min_duration = 0, log_buffers = on: 11106 tps
>> log_min_duration = -1 (off): 13297 tps
>>
>> So it is possible to measure it, at least.
> 
> Seems small enough not to worry about it.

Users can simply disable log_buffers if they enable log_analyze
but don't need buffer usage details and want to avoid the overhead.
If there were no way to avoid the overhead, I'd agree not to make
this change. But since we can disable log_buffers when needed,
I think it's acceptable.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation






view thread (32+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox