public inbox for [email protected]
help / color / mirror / Atom feedFrom: Fujii Masao <[email protected]>
To: Michael Christofides <[email protected]>
To: David Rowley <[email protected]>
Cc: Guillaume Lelarge <[email protected]>
Cc: Greg Sabino Mullane <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Nikolay Samokhvalov <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE
Date: Thu, 29 May 2025 13:28:45 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAFwT4nABCCOs242KoOToR54NVhDsHC73dm50qBWBwpt9unA3wg@mail.gmail.com>
References: <CANNMO++9W_UA8PB9AkDRF3JBv4K7K1FnisrXTjicL+WZhwUJzw@mail.gmail.com>
<CAECtzeWpusNrZADkQ01ZZL_fFtOWtwtnw_uixqy9hgK0qUCScQ@mail.gmail.com>
<CA+TgmoZO2HtDGHf7K4rmNdfUGuS=ngsPgwrH=JdyF6Okcnzfkw@mail.gmail.com>
<CAECtzeW=yo4H-G8rBheWwiET-e+PaBpOHHaL9Yu0JpYTd557_Q@mail.gmail.com>
<CAKAnmmLOkvJ85MGyouFBr2tS+0TSZ87=t=8iaZKU25WG98nZaw@mail.gmail.com>
<CAECtzeUwpK5gNWQqoK4ZjwXANtdE2fWirJyaBDqkytPzfWZqzg@mail.gmail.com>
<CAKAnmm+QQP-dTkjsDVbEcphrdXqCTq-ALTCMUwPaYWZmqUp=NQ@mail.gmail.com>
<CAECtzeVkkmvmHWVOTzwpX_GX+k4h7EWAyfERqes9C0z4pzMN2A@mail.gmail.com>
<CAApHDvpj0Cj6Z8VnDN5htzF24b4_hKL+1_n=HOehLHkBK_E_TQ@mail.gmail.com>
<CAECtzeUWiA+FNq0qGp94Ez4UAwbEZyB7avTqKDs6wkPhU56mpw@mail.gmail.com>
<CAApHDvqjmr=CZ2M57eErxn2Ubcb0d2EmppZhTj8k==Ud_eRfoQ@mail.gmail.com>
<CAApHDvqLdzgz77JsE-yTki3w9UiKQ-uTMLRctazcu+99-ips3g@mail.gmail.com>
<CAApHDvqJcsNsmU4d8q24qZy4Rm0OzxQ4jDRRNBV1P6xrYWwxCQ@mail.gmail.com>
<CAFwT4nABCCOs242KoOToR54NVhDsHC73dm50qBWBwpt9unA3wg@mail.gmail.com>
On 2024/12/14 0:59, Michael Christofides wrote:
> > I've pushed the main patch.
>
> Woohoo! And thank you. I've already seen quite a lot of positivity around the commit on Twitter[1][2][3].
>
> > I'm not planning on pushing the auto_explain.log_buffers default change unless there's a bit more discussion about it.
>
> Much like Guillaume, I'd also be in favour of 0002, but it's nowhere near as important to me. I think most people consider the parameters far more when setting up auto_explain, so I believe far fewer omit buffers by mistake. Also, most cloud providers don't ship with auto_explain on, and the only one I know of that does[4], ships with log_buffers on too. On the plus side, it would be nice to be consistent. But on the downside, it might add a little extra overhead for folks who run auto_explain with log_analyze on, and who opted not to set log_buffers and upgrade without setting it to off explicitly. I am still in favour of the 0002 patch being applied, to avoid confusion and maximise the chance people that don't know about buffers still get them in their plans.
I agree with changing the default value of auto_explain.log_buffers to true.
I think that users who know EXPLAIN ANALYZE includes buffers info in
the result by default since v18 would expect the buffer info also to
be included in auto_explain output as long as log_analyze is enabled.
So setting log_buffers to true by default would be less confusing.
As for 0002 patch, should the example log output with log_analyze enabled
also be updated to show the buffer information?
Sorry for reviving this old thread, but while testing the new v18 feature
- buffers being shown by default - I had the same thought about
auto_explain.log_buffers, so I wanted to chime in.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
view thread (32+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox