From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: !USE_WIDE_UPPER_LOWER compile errors in v10+
Date: Thu, 21 Sep 2017 17:38:13 -0400
Message-ID: <2653.1506029893@sss.pgh.pa.us> (raw)
In-Reply-To: <7963.1506001811@sss.pgh.pa.us>
References: <CAH2-WznnOrK=u-Ui2+vVk+-exMvAk9=nLbyaYVSmWCpAJ5en+A@mail.gmail.com>
<20170921052928.GA188913@rfd.leadboat.com>
<7963.1506001811@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
I wrote:
> Noah Misch <noah@leadboat.com> writes:
>> Perhaps it is time to require HAVE_WCSTOMBS and HAVE_TOWLOWER, removing
>> USE_WIDE_UPPER_LOWER? Every buildfarm fossil has both.
> +1 ... if nothing else, there's the problem that untested code is likely
> to be broken. You just proved it *is* broken, of course, but my point
> is that even if we repaired the immediate damage we could have little
> confidence in it staying fixed.
Further notes about that:
* The Single Unix Spec v2 (a/k/a POSIX 1997), which has been our minimum
portability spec for quite awhile, requires wcstombs() and towlower(),
and further requires the latter to be declared in <wctype.h>.
* Surveying the buildfarm, I agree with your conclusion that every active
member has wcstombs() and towlower(). gaur/pademelon is the lone member
that lacks <wctype.h>; it declares towlower() in <wchar.h> instead. It's
not so surprising that that system adheres to a pre-1997 idea of where to
put that, because its /usr/include files mostly date from 1996 ...
Meanwhile, I see that Peter has posted a fix for the immediate problem.
I propose that Peter should apply his fix in HEAD and v10, and then
I'll rip out the !USE_WIDE_UPPER_LOWER code paths in HEAD only.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, peter.eisentraut@2ndquadrant.com, pg@bowt.ie
Subject: Re: !USE_WIDE_UPPER_LOWER compile errors in v10+
In-Reply-To: <2653.1506029893@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox