pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tristan Partin <tristan@neon.tech>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: Refactoring backend fork+exec code
Date: Fri, 01 Dec 2023 18:55:22 -0500
Message-ID: <266005.1701474922@sss.pgh.pa.us> (raw)
In-Reply-To: <CXDB1KDXT43W.3JWSW74DO6JT3@neon.tech>
References: <7a59b073-5b5b-151e-7ed3-8b01ff7ce9ef@iki.fi>
	<20230710225043.svl7fqxecwshwc7a@awork3.anarazel.de>
	<119551e6-60f6-49b2-ae04-a382a89f900c@iki.fi>
	<e0dcfabb-f59a-45e8-bd92-f8d706c92128@iki.fi>
	<CXCDA9YFDZS1.Y5JUZBHLLXYR@neon.tech>
	<3b02a5a1-81ea-44e4-a09e-c0a594a4cef8@iki.fi>
	<014768ed-8b39-c44f-b07c-098c87b1644c@gmail.com>
	<a1b69a02-544a-471e-8b95-81256e992248@iki.fi>
	<CXDB1KDXT43W.3JWSW74DO6JT3@neon.tech>

"Tristan Partin" <tristan@neon.tech> writes:
> On Fri Dec 1, 2023 at 2:44 PM CST, Heikki Linnakangas wrote:
>> Committed a fix with memset(). I'm not sure what our policy with 
>> backpatching this kind of issues is. This goes back to all supported 
>> versions, but given the lack of complaints, I chose to not backpatch.

> Seems like a harmless think to backpatch. It is conceivable that someone 
> might want to run Valgrind on something other than HEAD.

FWIW, I agree with Heikki's conclusion.  EXEC_BACKEND on non-Windows
is already a niche developer-only setup, and given the lack of complaints,
nobody's that interested in running Valgrind with it.  Fixing it on HEAD
seems like plenty.

			regards, tom lane





view thread (50+ messages)  latest in thread

Message-ID: <266005.1701474922@sss.pgh.pa.us>
Permalink:  ../266005.1701474922@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/266005.1701474922@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, tristan@neon.tech, hlinnaka@iki.fi, exclusion@gmail.com, andres@anarazel.de, thomas.munro@gmail.com
  Subject: Re: Refactoring backend fork+exec code
  In-Reply-To: <266005.1701474922@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox