From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Fuzzy thinking in is_publishable_class
Date: Tue, 07 May 2019 17:30:05 -0400
Message-ID: <2661.1557264605@sss.pgh.pa.us> (raw)
In-Reply-To: <15150.1557257111@sss.pgh.pa.us>
References: <15150.1557257111@sss.pgh.pa.us>
I wrote:
> is_publishable_class has a test "relid >= FirstNormalObjectId",
> which I think we should drop, for two reasons:
> 1. It makes the comment claiming that this function tests the same
> things as check_publication_add_relation a lie.
> 2. The comment about it claims that the purpose is to reject
> information_schema relations, but if that's so, it's ineffective.
> We consider it supported to drop and recreate information_schema,
> and have indeed recommended doing so for some minor-version
> upgrades. After that, the information_schema relations would no
> longer have OIDs recognizable to this test.
> So what is the motivation for this test? If there's an important
> reason for it, we need to find a less fragile way to express it.
After further digging around, I wonder whether this test wasn't
somehow related to the issue described in
https://postgr.es/m/2321.1557263978@sss.pgh.pa.us
That doesn't completely make sense, since the restriction on
relkind should render it moot whether IsCatalogClass thinks
that a toast table is a catalog table, but maybe there's a link?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Fuzzy thinking in is_publishable_class
In-Reply-To: <2661.1557264605@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox