From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: subscription/t/010_truncate.pl failure on desmoxytes in REL_13_STABLE
Date: Thu, 24 Jun 2021 13:54:59 -0400
Message-ID: <2673480.1624557299@sss.pgh.pa.us> (raw)
In-Reply-To: <CAA4eK1Kft05mwNuZbTVRmz8SNS3r+uriuCT8DxL5KJy5btoS-A@mail.gmail.com>
References: <CA+hUKGKfxdQOpVpDhjJvtLThOHykApTN7VAM93zh5Ft-zgWxXQ@mail.gmail.com>
<CAA4eK1LpLJErZnz4_Vm-eFBHZa_NGqkgoQWHwrESA+YnbY9yvA@mail.gmail.com>
<CA+hUKGKRwSadbxnQfaj2Mtra2bwXS+nOo89J+mKViGhF2RVnAw@mail.gmail.com>
<1712887.1624368287@sss.pgh.pa.us>
<CAA4eK1Kft05mwNuZbTVRmz8SNS3r+uriuCT8DxL5KJy5btoS-A@mail.gmail.com>
Amit Kapila <amit.kapila16@gmail.com> writes:
> On Tue, Jun 22, 2021 at 6:54 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> BTW, the reason that the walsender is still showing its "query" as
>> "SELECT pg_config..." is that pre-v14 versions don't update the
>> reported query for replication commands, only plain-SQL commands.
>> I recall that we fixed that in HEAD awhile ago; should we consider
>> back-patching something for it?
> I think it would be great if we can do that. Analyzing such failures
> and in general for replication errors that will be a nice improvement
> and make the jobs of many people a bit easier.
Checking the git history, this was fixed in f560209c6, which also
included some other mostly-cosmetic cleanup. I'm inclined to
propose back-patching that whole commit, rather than allowing the
code in exec_replication_command() to diverge in different branches.
It looks like it applies cleanly as far back as v10. Maybe something
could be done for 9.6 as well, but since that branch is so close to
EOL, I doubt it's worth spending extra effort on it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, amit.kapila16@gmail.com, thomas.munro@gmail.com
Subject: Re: subscription/t/010_truncate.pl failure on desmoxytes in REL_13_STABLE
In-Reply-To: <2673480.1624557299@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox