pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Subject: Re: Statistics Import and Export
Date: Fri, 29 Mar 2024 19:47:42 -0400
Message-ID: <267624.1711756062@sss.pgh.pa.us> (raw)
In-Reply-To: <718fa933c2c58d0ecc61995ab5c7ca1fe78d6369.camel@j-davis.com>
References: <Zei1xMGH8SJS9yoc@tamriel.snowman.net>
	<54f190b6c757da2a33cce811949e9dd9601fcba7.camel@j-davis.com>
	<1632327b74a734f8c434eb75e824160d2b06a697.camel@j-davis.com>
	<CADkLM=dOUfTtpmE70mx5SmdEs11hic61G-wPa45pB1iC3NRABg@mail.gmail.com>
	<16412b8b7ae443cb7470006beff3011927048860.camel@j-davis.com>
	<CADkLM=cq1n2wbxhV23pOeUKReBPZxZyELDsDJ3VAxkYBSVAe0g@mail.gmail.com>
	<CADkLM=d_WYoFq75eoNHso+9EFDi=Q2BtCmxQYMjrgLL4=v5dxw@mail.gmail.com>
	<1b1bd1ec39ab3de09a17bf7b241021067e5bd63c.camel@j-davis.com>
	<CADkLM=eJXPQD=pWwwm+4Y48haiMmznB8dCECNMrwr59niY8ESw@mail.gmail.com>
	<2bce855db8259c5672a09f863a307ca07b967b68.camel@j-davis.com>
	<CADkLM=dw=fkvPRmOw74UDYnLzXwkDyMSY1k2jsU5=xXBAj7Mpw@mail.gmail.com>
	<5e94c358caedf2a231dd71624c3578db7227a265.camel@j-davis.com>
	<CADkLM=dztWa9shWHyq=+rS9KvbZQ2v54tnOcYT+g8psf0B7w_A@mail.gmail.com>
	<CADkLM=fFwkd7VbO4SPCyX-2f-fyGraka5J+5fcp1QMrCefu68Q@mail.gmail.com>
	<CADkLM=cioQmOFh98qQmqVEkVPjLYszEhZtNtUbmmNAdHOSr3WQ@mail.gmail.com>
	<bf724b21-914a-4497-! 84e3-49944f9776f6@enterprisedb.com>
	<4afa70edab849ff16238d1100b6652404e9a4d9d.camel@j-davis.com>
	<CADkLM=e=_6dtacmrvd2NJWacOnQ3Zu5iaRZFgePL1=0L5-7P_w@mail.gmail.com>
	<3df03aa65aa6ea3a76582e1a792e422dc5c32ad3.camel@j-davis.com>
	<CAOuzzgpfm9hROr_g8LouvpOeqv4yxk3qXPXU9Sn2nnqzPpP5UA@mail.gmail.com>
	<718fa933c2c58d0ecc61995ab5c7ca1fe78d6369.camel@j-davis.com>

Jeff Davis <pgsql@j-davis.com> writes:
> On Fri, 2024-03-29 at 18:02 -0400, Stephen Frost wrote:
>> I’d certainly think “with stats” would be the preferred default of
>> our users.

> What do you think about starting off with it as non-default, and then
> switching it to default in 18?

I'm with Stephen: I find it very hard to imagine that there's any
users who wouldn't want this as default.  If we do what you suggest,
then there will be three historical behaviors to cope with not two.
That doesn't sound like it'll make anyone's life better.

As for the "it might break" argument, that could be leveled against
any nontrivial patch.  You're at least offering an opt-out switch,
which is something we more often don't do.

(I've not read the patch yet, but I assume the switch works like
other pg_dump filters in that you can apply it on the restore
side?)

			regards, tom lane





view thread (543+ messages)  latest in thread

Message-ID: <267624.1711756062@sss.pgh.pa.us>
Permalink:  ../267624.1711756062@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/267624.1711756062@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql@j-davis.com, sfrost@snowman.net, ashutosh.bapat.oss@gmail.com, corey.huinker@gmail.com, boekewurm+postgres@gmail.com, smithpb2250@gmail.com, pgsql-hackers@lists.postgresql.org, tomas.vondra@enterprisedb.com
  Subject: Re: Statistics Import and Export
  In-Reply-To: <267624.1711756062@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox