From: Ronan Dunklau <ronan.dunklau@aiven.io>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Devrim Gündüz <devrim@gunduz.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Andres Freund <andres@anarazel.de>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Subject: Re: LLVM 16 (opaque pointers)
Date: Mon, 16 Oct 2023 10:31:32 +0200
Message-ID: <2700884.mvXUDI8C0e@aivenlaptop> (raw)
In-Reply-To: <CA+hUKGLxVtLCo3xD1OEnMSQbq04MKx1G_vQ5SZQNMBSFPR_TpA@mail.gmail.com>
References: <CA+hUKGKNX_=f+1C4r06WETKTq0G4Z_7q4L4Fxn5WWpMycDj9Fw@mail.gmail.com>
<5716086.DvuYhMxLoT@aivenlaptop>
<CA+hUKGLxVtLCo3xD1OEnMSQbq04MKx1G_vQ5SZQNMBSFPR_TpA@mail.gmail.com>
Le vendredi 13 octobre 2023, 22:32:13 CEST Thomas Munro a écrit :
> On Wed, Oct 11, 2023 at 10:31 PM Ronan Dunklau <ronan.dunklau@aiven.io>
wrote:
> > Le mercredi 11 octobre 2023, 10:59:50 CEST Thomas Munro a écrit :
> > > The back-patch to 12 was a little trickier than anticipated, but after
> > > taking a break and trying again I now have PG 12...17 patches that
> > > I've tested against LLVM 10...18 (that's 54 combinations), in every
> > > case only with the clang corresponding to LLVM.
> >
> > Thank you Thomas for those patches, and the extensive testing, I will run
> > my own and let you know.
>
> Thanks! No news is good news, I hope? I'm hoping to commit this today.
>
> > > I've attached only the patches for master, but the 12-16 versions are
> > > available at https://github.com/macdice/postgres/tree/llvm16-$N in
> > > case anyone has comments on those.
> >
> > For PG13 and PG12, it looks like the ExecEvalBoolSubroutineTemplate is not
> > used anywhere, as ExecEvalBoolSubroutine was introduced in PG14 if I'm not
> > mistaken.
>
> Right, looks like I can remove that in those branches.
Oh sorry I thought I followed up. I ran the same stress testing involving
several hours of sqlsmith with all jit costs set to zero and didn't notice
anything with LLVM16.
Thank you !
--
Ronan Dunklau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ronan.dunklau@aiven.io, thomas.munro@gmail.com, devrim@gunduz.org, pgsql-hackers@lists.postgresql.org, coelho@cri.ensmp.fr, andres@anarazel.de, 9erthalion6@gmail.com
Subject: Re: LLVM 16 (opaque pointers)
In-Reply-To: <2700884.mvXUDI8C0e@aivenlaptop>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox