From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: pgsql-hackers@lists.postgresql.org, Jaime Casanova <jcasanov@systemguards.com.ec>
Subject: Re: LogwrtResult contended spinlock
Date: Mon, 01 Jul 2024 10:59:18 -0400
Message-ID: <2741228.1719845958@sss.pgh.pa.us> (raw)
In-Reply-To: <202407011454.hni6ldpc3hoa@alvherre.pgsql>
References: <202407011454.hni6ldpc3hoa@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Maybe we can do something like this,
> +#if MAXIMUM_ALIGNOF >= 8
> uint64 currval;
This should probably be testing the alignment of int64 specifically,
rather than assuming that MAXIMUM_ALIGNOF applies to it. At least
historically, there have been platforms where MAXIMUM_ALIGNOF is
determined by float quantities and integer quantities are different.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, exclusion@gmail.com, bharath.rupireddyforpostgres@gmail.com, andres@anarazel.de, pgsql@j-davis.com, jcasanov@systemguards.com.ec
Subject: Re: LogwrtResult contended spinlock
In-Reply-To: <2741228.1719845958@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox