pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jacob Champion <pchampion@vmware.com>
To: john.naylor@enterprisedb.com <john.naylor@enterprisedb.com>
To: michael@paquier.xyz <michael@paquier.xyz>
Cc: pavel.stehule@gmail.com <pavel.stehule@gmail.com>
Cc: laurenz.albe@cybertec.at <laurenz.albe@cybertec.at>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: horikyota.ntt@gmail.com <horikyota.ntt@gmail.com>
Subject: Re: badly calculated width of emoji in psql
Date: Mon, 16 Aug 2021 17:04:32 +0000
Message-ID: <27788f6c85b9485c3dd845875a3fdc285560c8d9.camel@vmware.com> (raw)
In-Reply-To: <CAFBsxsG39ZQNKDQpE3Yu6rytemsCk8naJ9ib=WyiSUia24_3qw@mail.gmail.com>
References: <9e3c847108bac6041f50e86d08d8835f5cf7cd78.camel@vmware.com>
	<YPUtzT0J8cZByTkD@paquier.xyz>
	<f6a06ecdf378b50ed871e363aa9ac7e706101ab6.camel@cybertec.at>
	<c2a556a0158b642d6c597508d2a47059091e4d56.camel@vmware.com>
	<2f7ca10c7847f69267685beca7b5aa92dd876259.camel@vmware.com>
	<CAFj8pRCuaHgxa8M_FxmhGDg46qWp4yF-Xz_Xkj5NZT-F9fkQ1w@mail.gmail.com>
	<CAFBsxsEW0oAD2gdWQ9OQ8dS52iz476kWK2pqV1xmGuVjaygZTA@mail.gmail.com>
	<bedc833c3f60bbcd72ce613fc6a677be609d19dd.camel@vmware.com>
	<CAFBsxsGZTwzDnTs=TVM38CCTPP3Y0D3=h+UiWt8M83D5THHf9A@mail.gmail.com>
	<CAFBsxsFQ=scF=hgvrUWwDBzf1ZSkdmq1XRN4NJPMtniqNfpBCQ@mail.gmail.com>
	<YRnRFIe5ycU3GYaX@paquier.xyz>
	<CAFBsxsG39ZQNKDQpE3Yu6rytemsCk8naJ9ib=WyiSUia24_3qw@mail.gmail.com>

On Mon, 2021-08-16 at 11:24 -0400, John Naylor wrote:
> 
> On Sun, Aug 15, 2021 at 10:45 PM Michael Paquier <michael@paquier.xyz> wrote:
> 
> > How large do libpgcommon deliverables get with this patch?  Skimming
> > through the patch, that just looks like a couple of bytes, still.
> 
> More like a couple thousand bytes. That's because the width
> of mbinterval doubled. If this is not desirable, we could teach the
> scripts to adjust the width of the interval type depending on the
> largest character they saw.

True. Note that the combining character table currently excludes
codepoints outside of the BMP, so if someone wants combinations in
higher planes to be handled correctly in the future, the mbinterval for
that table may have to be widened anyway.

--Jacob


view thread (37+ messages)  latest in thread

Message-ID: <27788f6c85b9485c3dd845875a3fdc285560c8d9.camel@vmware.com>
Permalink:  ../27788f6c85b9485c3dd845875a3fdc285560c8d9.camel@vmware.com/
Also on:    postgresql.org/message-id/27788f6c85b9485c3dd845875a3fdc285560c8d9.camel@vmware.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: pchampion@vmware.com, john.naylor@enterprisedb.com, michael@paquier.xyz, pavel.stehule@gmail.com, laurenz.albe@cybertec.at, horikyota.ntt@gmail.com
  Subject: Re: badly calculated width of emoji in psql
  In-Reply-To: <27788f6c85b9485c3dd845875a3fdc285560c8d9.camel@vmware.com>
  References: <9e3c847108bac6041f50e86d08d8835f5cf7cd78.camel@vmware.com> <YPUtzT0J8cZByTkD@paquier.xyz> <f6a06ecdf378b50ed871e363aa9ac7e706101ab6.camel@cybertec.at> <c2a556a0158b642d6c597508d2a47059091e4d56.camel@vmware.com> <2f7ca10c7847f69267685beca7b5aa92dd876259.camel@vmware.com> <CAFj8pRCuaHgxa8M_FxmhGDg46qWp4yF-Xz_Xkj5NZT-F9fkQ1w@mail.gmail.com> <CAFBsxsEW0oAD2gdWQ9OQ8dS52iz476kWK2pqV1xmGuVjaygZTA@mail.gmail.com> <bedc833c3f60bbcd72ce613fc6a677be609d19dd.camel@vmware.com> <CAFBsxsGZTwzDnTs=TVM38CCTPP3Y0D3=h+UiWt8M83D5THHf9A@mail.gmail.com> <CAFBsxsFQ=scF=hgvrUWwDBzf1ZSkdmq1XRN4NJPMtniqNfpBCQ@mail.gmail.com> <YRnRFIe5ycU3GYaX@paquier.xyz> <CAFBsxsG39ZQNKDQpE3Yu6rytemsCk8naJ9ib=WyiSUia24_3qw@mail.gmail.com> <27788f6c85b9485c3dd845875a3fdc285560c8d9.camel@vmware.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox