pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Vitaly Davydov <v.davydov@postgrespro.ru>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Deadlock detector fails to activate on a hot standby replica
Date: Thu, 18 Jun 2026 16:11:27 +0300
Message-ID: <279402b1-7f16-43fa-9dbf-df96a93245dd@postgrespro.ru> (raw)
In-Reply-To: <CAHGQGwF01sOHnh6_9yDWiAdBMNnGWsTpM89+8XeztMjV=xk+cw@mail.gmail.com>
References: <44c24dcf-5710-410f-b1b6-d10b315f3d51@postgrespro.ru>
	<b178ea8d-9ed9-48b3-b4f7-5cfc3ff6ee44@postgrespro.ru>
	<CAHGQGwExVv1-mtPEX-JFGBXNY2r8DfP+sQVPD8GpDTefW0KdsQ@mail.gmail.com>
	<25cba756-9459-4811-aeaf-4a8715735c82@postgrespro.ru>
	<CAHGQGwFCqEkeaoUKHPJ5kpGjrKrJ5nzqE6NqjT-Rz3S6Zg7fug@mail.gmail.com>
	<CAHGQGwGNfwDH4hF_LnXzjnUd3d8+PF=f3dRbNn9XkL1hFbvRRQ@mail.gmail.com>
	<12324a50-95d3-4de4-bd89-b295924b35bb@postgrespro.ru>
	<CAHGQGwFED52rRVb_a=bVSdbOA=oARVOUyw381GC_6uKoNWJAtQ@mail.gmail.com>
	<b8f9bf41-8afa-46f5-9718-dc096bd666c0@postgrespro.ru>
	<CAHGQGwHh5j=sG3AZh=HyuXtPM6cmymp6MJkRAMJcJUyN2qpHrQ@mail.gmail.com>
	<CAHGQGwF01sOHnh6_9yDWiAdBMNnGWsTpM89+8XeztMjV=xk+cw@mail.gmail.com>

Dear Fujii Masao,

Thank you for the v5 patch. It looks good for me.

 > I still haven't come up with a good way to test this without depending on
 > log_startup_progress_interval being active during standby WAL replay.
 > Even so, I think the fix is still worth committing because it addresses
 > a real issue. So how about committing 0001 patch first, even without
 > a regression test?

I have no objections to commit the v5 patch without the tap-test. Once, it is
the bug fix, should we prepare the fix for other major branches? I'm ready to
prepare the patches based on the v5 version.

I looked at the tap test and found the reason why the test doesn't reproduce
the issue. The function adjust_conf in Cluster.pm changes the existing
parameter but doesn't add new new parameter to the configuration file if it is
missed. It doesn't report any errors as well. If to use the append_conf method
the test starts to reproduce the issue pretty stable, because the parameter is
actually added to the configuration file.

One more note - in my original test I set autovacuum = off for all nodes, but
in modified 031 test autovacuum seems to be enabled. Disabling autovacuum may
make the test more stable.

With best regards,
Vitaly





view thread (43+ messages)  latest in thread

Message-ID: <279402b1-7f16-43fa-9dbf-df96a93245dd@postgrespro.ru>
Permalink:  ../279402b1-7f16-43fa-9dbf-df96a93245dd@postgrespro.ru/
Also on:    postgresql.org/message-id/279402b1-7f16-43fa-9dbf-df96a93245dd@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: v.davydov@postgrespro.ru, masao.fujii@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Deadlock detector fails to activate on a hot standby replica
  In-Reply-To: <279402b1-7f16-43fa-9dbf-df96a93245dd@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox