From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Atsushi Torikoshi <atorik@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: RecoveryWalAll and RecoveryWalStream wait events
Date: Thu, 19 Mar 2020 15:34:49 +0900
Message-ID: <2811dcd9-2928-a08c-7034-23c021dbc0ec@oss.nttdata.com> (raw)
In-Reply-To: <CACZ0uYHJYrfdSSkGGvPKRUvGC1r_A908FBkLgPwwS4WYkEnxcg@mail.gmail.com>
References: <124997ee-096a-5d09-d8da-2c7a57d0816e@oss.nttdata.com>
<20200218.142016.2107516686265665330.horikyota.ntt@gmail.com>
<2ea0c6f1-adcd-f2a2-fe5a-92376ad38432@oss.nttdata.com>
<CACZ0uYE1UJomZ1tiB1vLwJSo_a2HAoXA6AF4=GRNfEkz-J1kNA@mail.gmail.com>
<aab7b94f-8140-48eb-3e31-698be55275d5@oss.nttdata.com>
<CACZ0uYFXtB3zYCW5p+nb9TXDnyUim6BctFaiBp7r4yUcfARCTQ@mail.gmail.com>
<bacc5242-50e1-3e1e-550d-df393861a1bf@oss.nttdata.com>
<CACZ0uYHJYrfdSSkGGvPKRUvGC1r_A908FBkLgPwwS4WYkEnxcg@mail.gmail.com>
On 2020/03/18 22:37, Atsushi Torikoshi wrote:
>
> On Wed, Mar 18, 2020 at 6:59 PM Fujii Masao <masao.fujii@oss.nttdata.com <mailto:masao.fujii@oss.nttdata.com>> wrote:
>
>
> I meant the following part in the doc.
>
> ---------------------
> At startup, the standby begins by restoring all WAL available in the archive
> location, calling restore_command. Once it reaches the end of WAL available
> there and restore_command fails, it tries to restore any WAL available in the
> pg_wal directory. If that fails, and streaming replication has been configured,
> the standby tries to connect to the primary server and start streaming WAL from
> the last valid record found in archive or pg_wal. If that fails or streaming
> replication is not configured, or if the connection is later disconnected,
> the standby goes back to step 1 and tries to restore the file from the archive
> again. This loop of retries from the archive, pg_wal, and via streaming
> replication goes on until the server is stopped or failover is triggered by a
> trigger file.
> ---------------------
>
>
> Thanks!
>
> > It seems the comment on WaitForWALToBecomeAvailable()
> > does not go along with the high-availability.sgml, do we need
> > modification on the comment on the function?
>
> No, I think for now. But you'd like to improve the docs?
>
>
> I'll do it.
>
> > But, anyway, you think that "pg_wal" should be used instead
> >
> > of "local" here?
> >
> >
> > I don't have special opinion here.
> > It might be better because high-availability.sgml does not use
> > "local" but "pg_wal" for the explanation, but I also feel it's
> > obvious in this context.
>
> Ok, I changed that from "local" to "pg_wal" in the patch for
> the master. Attached is the updated version of the patch.
> If you're OK with this, I'd like to commit two patches that I posted
> in this thread.
>
>
> Thanks for your modification and it looks good to me.
Pushed! Thanks a lot!
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, atorik@gmail.com, horikyota.ntt@gmail.com
Subject: Re: RecoveryWalAll and RecoveryWalStream wait events
In-Reply-To: <2811dcd9-2928-a08c-7034-23c021dbc0ec@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox