pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Jelte Fennema <postgres@jeltef.nl>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: shiy.fnst@fujitsu.com <shiy.fnst@fujitsu.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Jesse Zhang <sbjesse@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Tue, 17 Oct 2023 12:16:55 -0400
Message-ID: <2817120.1697559415@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-Wz=ceqmox2r-WGpwnM4j1O6Dy0dE29i8i_09Cz2BpEVh=g@mail.gmail.com>
References: <CAGECzQTvfpkyyRoGscSuS7ySCEXOO1DCi3eztHQbGEDrj_nt4g@mail.gmail.com>
	<30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net>
	<1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net>
	<CAH2-WznOKBQ3HvdwvyXHz18T2u-brkE5umDUic4B-2vtavJKqA@mail.gmail.com>
	<20230811212511.aih23qfthi24zhq4@awork3.anarazel.de>
	<CAH2-Wz=+23=O6iioUR_k9-mgUoX2kJPOWW5JdOXmd5dCtvinVg@mail.gmail.com>
	<338202.1691793002@sss.pgh.pa.us>
	<CAH2-Wz=TNXWQWFgZPehFyPo+9HxxwuHHHYA-ymR+W+kMChM+9Q@mail.gmail.com>
	<342032.1691794926@sss.pgh.pa.us>
	<8c4d8afb-cda1-299c-8011-f60cdaff3999@dunslane.net>
	<20230812211404.sydbwo2juu7vyhtg@awork3.anarazel.de>
	<530189.1691880417@sss.pgh.pa.us>
	<CAH2-Wz=OXmLbQ9ykYYSTmadD=fHtn7-ctCqsco7rc2s3Fvx8QQ@mail.gmail.com>
	<544112.1691886017@sss.pgh.pa.us>
	<CAH2-WzmueQvoZVScpUcAes3Gq_OGCnOH1RXyMicrMdyaAg6OLA@mail.gmail.com>
	<CAH2-WznZ4g8mrHCPVr5MBcSFenFnaKPp2K52JvqLt2fjdcR-bg@mail.gmail.com>
	<CA+TgmoYPycBvESpVkTsEEDrt8PbUnLR1SHSYOKzM_bnkd-UkfQ@mail.gmail.com>
	<CA+TgmoYdrQkr6BBekHJq-1Dga! n=Vuz0kGsfZdJ5_0jx9s+zzqw@mail.gmail.com>
	<2718058.1697552602@sss.pgh.pa.us>
	<CA+TgmoZ0QR-ucfR=-wEy3NbZNbg16+vqzdNEYLVXr20ukdN5fg@mail.gmail.com>
	<CAH2-WzmXc-8W_P=EuOGEHVMM6S=GaxGGpk5hv3Rgvz11U_jHOA@mail.gmail.com>
	<CA+TgmoaGE-hw91z=QtdueSXOcLVcpdCFKkFG6Qw4O4XHn8sh7g@mail.gmail.com>
	<CAH2-Wz=1nh_-thRAYmBgN=xKmxAS-jzb8tt0UVOuN1f5FmEhKQ@mail.gmail.com>
	<CAGECzQQNTuLGxPN6uUG-wmw+md0ngdCo9SLeBA=UY5ytft0oAg@mail.gmail.com>
	<CAH2-Wz=ceqmox2r-WGpwnM4j1O6Dy0dE29i8i_09Cz2BpEVh=g@mail.gmail.com>

Peter Geoghegan <pg@bowt.ie> writes:
> That's beside the point. The point is that I'm obligated to keep
> typedef.list up to date in general, a task that is made significantly
> harder by random objdump implementation details. And I probably need
> to do this not just once per commit, but several times, since in
> practice I need to defensively run and rerun pgindent as the patch is
> tweaked.

Hmm, I've not found it that hard to manage the typedefs list.
If I run pgindent and it adds weird spacing around uses of a new
typedef name, I go "oh, I better add that to the list" and do so.
End of problem.  There's not a requirement that you remove disused
typedef names, nor that you alphabetize perfectly.  I'm content
to update those sorts of details from the buildfarm's list once a
year or so.

This does assume that you inspect pgindent's changes rather than
just accepting them blindly --- but as I commented upthread, the
tool really requires that anyway.

			regards, tom lane





view thread (308+ messages)  latest in thread

Message-ID: <2817120.1697559415@sss.pgh.pa.us>
Permalink:  ../2817120.1697559415@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2817120.1697559415@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, postgres@jeltef.nl, robertmhaas@gmail.com, andres@anarazel.de, andrew@dunslane.net, michael@paquier.xyz, shiy.fnst@fujitsu.com, pryzby@telsasoft.com, noah@leadboat.com, bruce@momjian.us, magnus@hagander.net, alvherre@2ndquadrant.com, sfrost@snowman.net, sbjesse@gmail.com, peter.eisentraut@enterprisedb.com
  Subject: Re: run pgindent on a regular basis / scripted manner
  In-Reply-To: <2817120.1697559415@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox