From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Cc: schmiddy@gmail.com
Subject: Re: hyrax versus isolationtester.c's hard-wired timeouts
Date: Mon, 09 Dec 2019 14:34:29 -0500
Message-ID: <28259.1575920069@sss.pgh.pa.us> (raw)
In-Reply-To: <22964.1575842935@sss.pgh.pa.us>
References: <22964.1575842935@sss.pgh.pa.us>
I wrote:
> There are two things we could do about this:
> 1. Knock the hard-wired setting up a tad, maybe to 5 minutes.
> Easy but doesn't seem terribly future-proof.
> 2. Make the limit configurable somehow, probably from an
> environment variable. There's precedent for that (PGCTLTIMEOUT),
> and it would provide a way for owners of especially slow buildfarm
> members to adjust things ... but it would require owners of
> especially slow buildfarm animals to adjust things.
> Any preferences? (Actually, it wouldn't be unreasonable to do
> both things, I suppose.)
> BTW, I notice that isolationtester.c fails to print any sort of warning
> notice when it decides it's waited too long. This seems like a
> spectacularly bad idea in hindsight: it's not that obvious why the test
> case failed. Plus there's no way to tell exactly which connection it
> decided to send a PQcancel to. So independently of the timeout-length
> issue, I think we ought to also make it print something like
> "isolationtester: waited too long for something to happen, canceling
> step thus-and-so".
I pushed a patch doing all of the above. This should be enough to
fix hyrax's problem without any manual adjustments of the animal's
configuration ... unless I've misdiagnosed what's happening.
We shall see.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, schmiddy@gmail.com
Subject: Re: hyrax versus isolationtester.c's hard-wired timeouts
In-Reply-To: <28259.1575920069@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox