pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: EINTR in ftruncate()
Date: Thu, 14 Jul 2022 11:24:49 -0400
Message-ID: <2834561.1657812289@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGKx6Biq7_UuV0kn9DW+8QWcpJC1qwhizdtD9tN-fn0H0g@mail.gmail.com>
References: <20220706002015.57q6dvife3c3fjxz@awork3.anarazel.de>
	<20220706192941.av3nxh4sdozyn5qz@alvherre.pgsql>
	<20220706203859.qbem3yjlvx2xbegc@alap3.anarazel.de>
	<CA+hUKGKS2Radu-1Ewhe1-LEj19C-3XAQ7wnkQMb4e9E9q9ZXSg@mail.gmail.com>
	<20220706210323.bjjzokyj6nzvofm3@alap3.anarazel.de>
	<CA+hUKGJj=+GVjtLaeT7sD1gnS6tn=4Lb5+iACf4RT7wBuguLZg@mail.gmail.com>
	<CA+hUKGJSm-nq8s+_59zb7NbFQF-OS=xTnTAiGLrQpuSmU2y_1A@mail.gmail.com>
	<20220711174518.yldckniicknsxgzl@awork3.anarazel.de>
	<CA+hUKGKfH8kfF_SUqAxxxOTX=EvwdgJx61d89Hj--mKnhOjGEQ@mail.gmail.com>
	<CA+hUKGKNpK=2OMeea_AZwpLg7Bm4=gYWk7eDjZ5F6YbozfOf8w@mail.gmail.com>
	<CA+hUKGKx6Biq7_UuV0kn9DW+8QWcpJC1qwhizdtD9tN-fn0H0g@mail.gmail.com>

Thomas Munro <thomas.munro@gmail.com> writes:
> ... but now I'm wondering if we should be more defensive and possibly
> even save/restore the mask.

+1, sounds like a more future-proof solution.

> Originally I discounted that because I
> thought I had to go through PG_SETMASK for portability reasons, but on
> closer inspection, I don't see any reason not to use sigprocmask
> directly in Unix-only code.

Seems like the thing to do is to add a suitable operation to the
pqsignal.h API.  We could leave it unimplemented for now on Windows,
and then worry what to do if we ever need it in that context.

			regards, tom lane





view thread (32+ messages)  latest in thread

Message-ID: <2834561.1657812289@sss.pgh.pa.us>
Permalink:  ../2834561.1657812289@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2834561.1657812289@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, andres@anarazel.de, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: EINTR in ftruncate()
  In-Reply-To: <2834561.1657812289@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox