From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: EINTR in ftruncate()
Date: Thu, 14 Jul 2022 11:27:24 -0400
Message-ID: <2835511.1657812444@sss.pgh.pa.us> (raw)
In-Reply-To: <20220714144652.jph7exiywushg4gc@alvherre.pgsql>
References: <20220714144652.jph7exiywushg4gc@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> ISTM it would be cleaner to patch PG_SETMASK to have a second argument
> and to return the original mask if that's not NULL. This is more
> invasive, but there aren't that many callsites of that macro.
[ shoulda read your message before replying ]
Given that this needs back-patched, I think changing PG_SETMASK
is a bad idea: there might be outside callers. However, we could
add another macro with the additional argument. PG_GET_AND_SET_MASK?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, thomas.munro@gmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: EINTR in ftruncate()
In-Reply-To: <2835511.1657812444@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox