From: Tom Lane <tgl@sss.pgh.pa.us>
To: Gregory Stark <stark@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: CSStorm occurred again by postgreSQL8.2
Date: Thu, 14 Sep 2006 09:57:59 -0400
Message-ID: <28515.1158242279@sss.pgh.pa.us> (raw)
In-Reply-To: <28167.1158241250@sss.pgh.pa.us>
References: <20060808110913.50FA.ITAGAKI.TAKAHIRO@oss.ntt.co.jp>
<200608260346.k7Q3k2g06954@momjian.us>
<20060828181312.5638.ITAGAKI.TAKAHIRO@oss.ntt.co.jp>
<13251.1157299738@sss.pgh.pa.us>
<22080.1158198335@sss.pgh.pa.us>
<87mz92so6n.fsf@enterprisedb.com>
<27509.1158237711@sss.pgh.pa.us>
<28167.1158241250@sss.pgh.pa.us>
I wrote:
> I see a bug though, which is that RecordSubTransactionAbort() calls
> GetCurrentTransactionId() before having verified that it needs to do
> anything. This means that we'll generate and then discard an XID
> uselessly in a failed subxact that didn't touch disk.
Well, it would be a bug except that RecordSubTransactionAbort isn't
called unless the current subxact has an XID. Perhaps a comment would
be appropriate but there's nothing to fix here.
I think Theo's problem is probably somewhere else, too --- apparently
it's not so much that TransactionIdIsCurrentTransactionId takes a long
time as that something is calling it lots of times with no check for
interrupt.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, stark@enterprisedb.com, alvherre@alvh.no-ip.org, itagaki.takahiro@oss.ntt.co.jp, bruce@momjian.us
Subject: Re: CSStorm occurred again by postgreSQL8.2
In-Reply-To: <28515.1158242279@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox