pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Missing errcode() in ereport
Date: Wed, 25 Mar 2020 01:39:57 -0400
Message-ID: <28622.1585114797@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGJ35GzhsLgKDFQ7MQN6piiZLLZ+MTevvYxbw=_GHpsP=A@mail.gmail.com>
References: <32174.1584454158@sss.pgh.pa.us>
	<20200319175902.vjib2tslosw65iyr@alap3.anarazel.de>
	<5063.1584641224@sss.pgh.pa.us>
	<20200319230446.lxjybufdcgwaqkhj@alap3.anarazel.de>
	<5995.1584660775@sss.pgh.pa.us>
	<20200320015908.ajxneh4jx6avqegv@alap3.anarazel.de>
	<9966.1584671550@sss.pgh.pa.us>
	<20200320045637.n3xo6gcmbqcg42tq@alap3.anarazel.de>
	<15922.1584715221@sss.pgh.pa.us>
	<31649.1584998689@sss.pgh.pa.us>
	<20200324193834.dojfetuxqupii577@alap3.anarazel.de>
	<6677.1585081791@sss.pgh.pa.us>
	<CA+hUKGJ35GzhsLgKDFQ7MQN6piiZLLZ+MTevvYxbw=_GHpsP=A@mail.gmail.com>

Thomas Munro <thomas.munro@gmail.com> writes:
> I think this caused anole to say:

> "reloptions.c", line 1362: error #2042: operand types are incompatible
> ("void" and "int")
>   errdetail_internal("%s", _(optenum->detailmsg)) : 0));

Yeah, I was just looking at that :-(

We could revert the change to have these functions return void,
or we could run around and change the places with this usage
pattern to use "(void) 0" instead of just "0".  The latter would
be somewhat painful if only minority compilers warn, though.
Also, I don't think that having to change ereport usage was part
of the agreed-to plan here ... so I'm leaning to the former.

			regards, tom lane





view thread (31+ messages)  latest in thread

Message-ID: <28622.1585114797@sss.pgh.pa.us>
Permalink:  ../28622.1585114797@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/28622.1585114797@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, andres@anarazel.de, amit.kapila16@gmail.com, michael@paquier.xyz, rjuju123@gmail.com, masahiko.sawada@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Missing errcode() in ereport
  In-Reply-To: <28622.1585114797@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox