From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add an optional timeout clause to isolationtester step.
Date: Mon, 09 Mar 2020 22:32:27 -0400
Message-ID: <28752.1583807547@sss.pgh.pa.us> (raw)
In-Reply-To: <20200310021459.GA4369@paquier.xyz>
References: <CAOBaU_Z=qkE42VQ25mps+zyAz+WUn3wZoev4uhGW+gAXBBS2YA@mail.gmail.com>
<20200305035354.GQ2593@paquier.xyz>
<20200306131547.GA2904@nol>
<20200307014142.GC1531@paquier.xyz>
<20200307061615.c47sju2bytuiaazv@nol>
<8441.1583595994@sss.pgh.pa.us>
<20200307205328.ffidfyo3me46qscn@nol>
<15903.1583615371@sss.pgh.pa.us>
<20200307211709.6kfpiddif4uxafg5@nol>
<20200309221558.7kd5fuks2alvtsex@alap3.anarazel.de>
<20200310021459.GA4369@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Mar 09, 2020 at 03:15:58PM -0700, Andres Freund wrote:
>> That kind of thing can already be done using statement_timeout or
>> lock_timeout, no?
> Yep, still that's not something I would recommend to commit in the
> tree as that's a double-edged sword as you already know. For slower
> machines, you need a statement_timeout large enough so as you make
> sure that the state you want the query to wait for is reached, which
> has a cost on all other faster machines as it makes the tests slower.
It strikes me to wonder whether we could improve matters by teaching
isolationtester to watch for particular values in a connected backend's
pg_stat_activity.wait_event_type/wait_event columns. Those columns
didn't exist when isolationtester was designed, IIRC, so it's not
surprising that they're not used in the current design. But we could
use them perhaps to detect that a backend has arrived at some state
that's not a heavyweight-lock-wait state.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, andres@anarazel.de, rjuju123@gmail.com
Subject: Re: Add an optional timeout clause to isolationtester step.
In-Reply-To: <28752.1583807547@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox