From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Ian Lawrence Barwick <barwick@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCH] remove deprecated v8.2 containment operators
Date: Fri, 13 Nov 2020 10:57:55 -0500
Message-ID: <287835.1605283075@sss.pgh.pa.us> (raw)
In-Reply-To: <87f709e5-6d3e-0e65-8f83-0a19a2343388@enterprisedb.com>
References: <20201027032511.GF9241@telsasoft.com>
<155ecfd8-7ac6-1875-5090-d79a586a8847@enterprisedb.com>
<235561.1605220100@sss.pgh.pa.us>
<87f709e5-6d3e-0e65-8f83-0a19a2343388@enterprisedb.com>
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 2020-11-12 23:28, Tom Lane wrote:
>> I'm on board with pulling these now --- 8.2 to v14 is plenty of
>> deprecation notice. However, the patch seems incomplete in that
>> the code support for these is still there -- look for
>> RTOldContainedByStrategyNumber and RTOldContainsStrategyNumber.
>> Admittedly, there's not much to be removed except some case labels,
>> but it still seems like we oughta do that to avoid future confusion.
> Yeah, the stuff in gistproc.c should be removed now. But I wonder what
> the mentions in brin_inclusion.c are and whether or how they should be
> removed.
I think those probably got cargo-culted in there at some point.
They're visibly dead code, because there are no pg_amop entries
for BRIN opclasses with amopstrategy 13 or 14.
This comment that you removed in 2f70fdb06 is suspicious:
# we could, but choose not to, supply entries for strategies 13 and 14
I'm guessing that somebody was vacillating about whether it'd be
a feature to support these old operator names in BRIN, and
eventually didn't, but forgot to remove the code support.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pryzby@telsasoft.com, hlinnaka@iki.fi, sfrost@snowman.net, barwick@gmail.com
Subject: Re: [PATCH] remove deprecated v8.2 containment operators
In-Reply-To: <287835.1605283075@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox