pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: WIP: Faster Expression Processing v4
Date: Tue, 14 Mar 2017 23:23:48 -0400
Message-ID: <28939.1489548228@sss.pgh.pa.us> (raw)
In-Reply-To: <20170314234016.5jgz4tjim2xf6j3c@alap3.anarazel.de>
References: <20161206034955.bh33paeralxbtluv@alap3.anarazel.de>
	<20170209003312.rr7atqepgbrf4xqe@alap3.anarazel.de>
	<20170307030137.lpo4japv5oqgbqpz@alap3.anarazel.de>
	<2090fd00-4dec-7b42-f700-64308958504c@2ndquadrant.com>
	<20170313080351.4g5oubxcj4xj5y7t@alap3.anarazel.de>
	<fcdaa51b-e905-72e0-39dd-5e22f535a253@2ndquadrant.com>
	<20170314065259.ffef4tfhgbsaieoe@alap3.anarazel.de>
	<69b7bb0e-8dab-3d39-1a89-3c6ab6409f64@iki.fi>
	<20170314224706.nxvtapenky6eom3z@alap3.anarazel.de>
	<21290.1489534452@sss.pgh.pa.us>
	<20170314234016.5jgz4tjim2xf6j3c@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Andres Freund <andres@anarazel.de> writes:
> On 2017-03-14 19:34:12 -0400, Tom Lane wrote:
>> It seems bizarre that you chose to spell the new configure symbol as
>> HAVE__COMPUTED_GOTO rather than HAVE_COMPUTED_GOTO

> I went back-and-forth about this a number of times.  We have a bunch of
> symbols defined with HAVE__ as a prefix (and some with HAVE_GCC__) - and
> more of the nearby code seems to use __ rather than _.  I don't really
> know why we started doing that, but it's far from new..

> Any idea why we introduce __ stuff?

The nearby stuff is describing features that have a specific name that
includes a leading underscore or two, like __builtin_unreachable().
That doesn't seem to apply here, so I wouldn't add extra underscores.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (107+ messages)  latest in thread

Message-ID: <28939.1489548228@sss.pgh.pa.us>
Permalink:  ../28939.1489548228@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/28939.1489548228@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, hlinnaka@iki.fi, tomas.vondra@2ndquadrant.com
  Subject: Re: WIP: Faster Expression Processing v4
  In-Reply-To: <28939.1489548228@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox