pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Thom Brown <thom@linux.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: Command Triggers, patch v11
Date: Fri, 09 Mar 2012 10:05:05 -0500
Message-ID: <29000.1331305505@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoYPSkm7BVaNZasKXB3O=bh1ewX3PzWKF8pODMRzXS5HaQ@mail.gmail.com>
References: <m24nufq466.fsf@2ndQuadrant.fr>
	<CAA-aLv4kv3DXuwXdDyU2qcWLjvYCsVo5=qTZq+t8uk5S9sAkqQ@mail.gmail.com>
	<CAA-aLv5paBN4P-cXUsu=KMQva-SCSjo9MpzM6szYFt5wqeFkeg@mail.gmail.com>
	<201203041650.39826.andres@anarazel.de>
	<CAA-aLv66UQ3mqsk96AUhc9zqw8hwEPdCrGHv81+F3=puSiw5Jg@mail.gmail.com>
	<m2mx7uye3r.fsf@2ndQuadrant.fr>
	<CAA-aLv6SioRE8MAED2z=0c2NZpf1q5jztwjzE6+gvGLbniV7aw@mail.gmail.com>
	<m2ty21fnkw.fsf@2ndQuadrant.fr>
	<CAA-aLv5-KAMD_PMEUK=SiG_OBdM4jiQ3O=kpw8fZM+-Uq4PJ1g@mail.gmail.com>
	<CAA-aLv46eeyi_ecPLOaY61OL5e+BWkba4_qrJ7V+=u2afbwCMg@mail.gmail.com>
	<CAA-aLv6qP56ktrjmfqPpOQHySCXU9b5Dz-ZJvNq1M9XP2cPhHw@mail.gmail.com>
	<CA+TgmoajeRakMPes_b63T++e9idLSZLnPC2WgL9fPAOXeMveVQ@mail.gmail.com>
	<CAA-aLv5ORQ5YhcFnPphLYjpYgAVqXBbGtdMVTitGhAqw2b2PWg@mail.gmail.com>
	<CA+TgmoYPSkm7BVaNZasKXB3O=bh1ewX3PzWKF8pODMRzXS5HaQ@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Mar 9, 2012 at 9:22 AM, Thom Brown <thom@linux.com> wrote:
>> Sorry, I meant any command trigger.  It's because none of the commands
>> can be run on a standby, so the triggers don't seem appropriate.

> I'm not convinced.  Right now, it's fairly useless - all the triggers
> could possibly do is throw an error, and an error is going to get
> thrown anyway, so it's only a question of which error message the user
> will see.  But we discussed before the idea of adding a capability for
> BEFORE triggers to request that the actual execution of the command
> get skipped, and then it's possible to imagine this being useful.

Um, surely the "you can't do that in a read-only session" error is going
to get thrown long before the command trigger could be called?

			regards, tom lane



view thread (115+ messages)  latest in thread

Message-ID: <29000.1331305505@sss.pgh.pa.us>
Permalink:  ../29000.1331305505@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/29000.1331305505@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, thom@linux.com, dimitri@2ndquadrant.fr, andres@anarazel.de
  Subject: Re: Command Triggers, patch v11
  In-Reply-To: <29000.1331305505@sss.pgh.pa.us>
  References: <m24nufq466.fsf@2ndQuadrant.fr> <CAA-aLv4kv3DXuwXdDyU2qcWLjvYCsVo5=qTZq+t8uk5S9sAkqQ@mail.gmail.com> <CAA-aLv5paBN4P-cXUsu=KMQva-SCSjo9MpzM6szYFt5wqeFkeg@mail.gmail.com> <201203041650.39826.andres@anarazel.de> <CAA-aLv66UQ3mqsk96AUhc9zqw8hwEPdCrGHv81+F3=puSiw5Jg@mail.gmail.com> <m2mx7uye3r.fsf@2ndQuadrant.fr> <CAA-aLv6SioRE8MAED2z=0c2NZpf1q5jztwjzE6+gvGLbniV7aw@mail.gmail.com> <m2ty21fnkw.fsf@2ndQuadrant.fr> <CAA-aLv5-KAMD_PMEUK=SiG_OBdM4jiQ3O=kpw8fZM+-Uq4PJ1g@mail.gmail.com> <CAA-aLv46eeyi_ecPLOaY61OL5e+BWkba4_qrJ7V+=u2afbwCMg@mail.gmail.com> <CAA-aLv6qP56ktrjmfqPpOQHySCXU9b5Dz-ZJvNq1M9XP2cPhHw@mail.gmail.com> <CA+TgmoajeRakMPes_b63T++e9idLSZLnPC2WgL9fPAOXeMveVQ@mail.gmail.com> <CAA-aLv5ORQ5YhcFnPphLYjpYgAVqXBbGtdMVTitGhAqw2b2PWg@mail.gmail.com> <CA+TgmoYPSkm7BVaNZasKXB3O=bh1ewX3PzWKF8pODMRzXS5HaQ@mail.gmail.com> <29000.1331305505@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox