From: Nikolay Shaplov <dhyan@nataraj.su>
To: pgsql-hackers@lists.postgresql.org
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCH][PROPOSAL] Add enum releation option type
Date: Thu, 15 Feb 2018 18:37:20 +0300
Message-ID: <29235994.NprrEGRed4@x200m> (raw)
In-Reply-To: <20180209214529.mbz6iqji7v436xde@alvherre.pgsql>
References: <20180209214529.mbz6iqji7v436xde@alvherre.pgsql>
В письме от 9 февраля 2018 18:45:29 пользователь Alvaro Herrera написал:
> Maybe we need some in-core user to verify the string case still works.
> A new module in src/test/modules perhaps?
I've looked attentively in src/test/modules... To properly test all reloptions
hooks for modules wee need to create an extension with some dummy index in it.
This way we can properly test everything. Creating dummy index would be fun,
but it a quite big deal to create it, so it will require a separate patch to
deal with. So I suppose string reloptions is better to leave untested for now,
with a notion, that it should be done sooner or later
> I don't much like the way you've represented the list of possible values
> for each enum. I think it'd be better to have a struct that represents
> everything about each value (string name and C symbol. Maybe the
> numerical value too if that's needed, but is it? I suppose all code
> should use the C symbol only, so why do we care about the numerical
> value?).
One more reason to keep numeric value, that came to my mind, is that it seems
to be logical to keep enum value in postgres internals represented as C-enum.
And C-enum is actually an int value (can be easily casted both ways). It is
not strictly necessary, but it seems to be a bit logical...
--
Do code for fun.
Attachments:
[application/pgp-signature] signature.asc (472B, ../29235994.NprrEGRed4@x200m/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dhyan@nataraj.su, pgsql-hackers@lists.postgresql.org, alvherre@alvh.no-ip.org
Subject: Re: [PATCH][PROPOSAL] Add enum releation option type
In-Reply-To: <29235994.NprrEGRed4@x200m>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox