From: Tom Lane <tgl@sss.pgh.pa.us>
To: Marina Polyakova <m.polyakova@postgrespro.ru>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: master plpython check fails on Solaris 10
Date: Wed, 14 Feb 2018 11:51:54 -0500
Message-ID: <29751.1518627114@sss.pgh.pa.us> (raw)
In-Reply-To: <82168d2485db48a0267c1451ed357651@postgrespro.ru>
References: <156b989dbc6fe7c4d3223cf51da61195@postgrespro.ru>
<4a5588c7-9bcc-d5f5-b952-6b260467fc71@2ndquadrant.com>
<2982e7d95f11eea5599f8141efbf4b2d@postgrespro.ru>
<17568.1518620054@sss.pgh.pa.us>
<82168d2485db48a0267c1451ed357651@postgrespro.ru>
Marina Polyakova <m.polyakova@postgrespro.ru> writes:
> On 14-02-2018 17:54, Tom Lane wrote:
>> I think we need to fix the error callback code so that it
>> uses the "arg" field to find the relevant procedure, and that
>> that's a back-patchable fix, because nested plpython functions
>> would show this up as wrong in any case. That would also let us
>> undo the not-terribly-safe practice of having code between the
>> PLy_push_execution_context call and the PG_TRY that is supposed
>> to ensure the context gets popped again.
> Thank you very much! I'll try to implement this.
I hsve a patch mostly done already.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, m.polyakova@postgrespro.ru, peter.eisentraut@2ndquadrant.com
Subject: Re: master plpython check fails on Solaris 10
In-Reply-To: <29751.1518627114@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox