From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Euler Taveira <euler@timbira.com.br>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Joe Conway <mail@joeconway.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Upgrading postmaster's log messages about bind/listen errors
Date: Tue, 14 Mar 2017 12:50:09 -0400
Message-ID: <29761.1489510209@sss.pgh.pa.us> (raw)
In-Reply-To: <17211.1489189214@sss.pgh.pa.us>
References: <20170310202722.shpauoi6zcpptu2k@alvherre.pgsql>
<29712.1489177966@sss.pgh.pa.us>
<17211.1489189214@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
I wrote:
>> I think that what would actually be of some use nowadays is a LOG-level
>> message emitted if the wraparound *isn't* activated immediately at start.
>> But otherwise, we should follow the rule that silence is golden.
> Concretely, how about the attached? It preserves the original
> "protections are now enabled" message at LOG level, but emits it only
> when oldestOffsetKnown becomes true *after* startup. Meanwhile, if
> oldestOffsetKnown is still not true at the conclusion of TrimMultiXact,
> then it emits a new LOG message about "protections are not active".
I realized that the second of these is not necessary because it's
redundant with the message about "MultiXact member wraparound protections
are disabled because oldest checkpointed MultiXact %u does not exist on
disk". Pushed without that.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, euler@timbira.com.br, robertmhaas@gmail.com, mail@joeconway.com
Subject: Re: Upgrading postmaster's log messages about bind/listen errors
In-Reply-To: <29761.1489510209@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox