pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jeff Davis <pgsql@j-davis.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Default setting for enable_hashagg_disk
Date: Fri, 10 Jul 2020 11:34:44 -0700
Message-ID: <29847045df67838cd72dc2dfe830a11642fb7153.camel@j-davis.com> (raw)
In-Reply-To: <2107841.1594403217@sss.pgh.pa.us>
References: <85F9F4F0-918A-457F-BC9E-F2AC2EFC1F86@anarazel.de>
	<20200625225853.GA11137@alvherre.pgsql>
	<20200708140037.GI3125@tamriel.snowman.net>
	<99b047386525b87df1e611335c2e57a6cdef346b.camel@j-davis.com>
	<20200709140330.GO3125@tamriel.snowman.net>
	<CAH2-WzmB04dxgRgjDGvDbugEFfHxMi2pyuJqsYr30x1RAEqSXg@mail.gmail.com>
	<20200709225840.GE12375@tamriel.snowman.net>
	<CAH2-WzmbycnZnxFTYnwkSkCPTVQbRoLiuEvo8gkZCKiQTL8GAQ@mail.gmail.com>
	<20200710000842.GF12375@tamriel.snowman.net>
	<CAH2-Wz=9f-gxPmqL9Lak0xddPmH0bgfAEioK+2BwTkuzyrtZEQ@mail.gmail.com>
	<20200710141714.GI12375@tamriel.snowman.net>
	<CAH2-Wzkd7cWK-mMPMb63JXxj2QFMan6hw+cQjdJKvdtCOpR7Ng@mail.gmail.com>
	<2107841.1594403217@sss.pgh.pa.us>

On Fri, 2020-07-10 at 13:46 -0400, Tom Lane wrote:
> I looked over Peter's patch in [1], and it seems generally pretty
> sane to me, though I concur with the idea that it'd be better to
> define the GUC as a multiplier for work_mem.  (For one thing, we
> could
> then easily limit it to be at least 1.0, ensuring sanity; also, if
> work_mem does eventually become more dynamic than it is now, we might
> still be able to salvage this knob as something useful.  Or if not,
> we just rip it out.)  So my vote is for moving in that direction.

In that case, I will hold off on my "escape-hatch" GUC.

Regards,
	Jeff Davis







view thread (218+ messages)  latest in thread

Message-ID: <29847045df67838cd72dc2dfe830a11642fb7153.camel@j-davis.com>
Permalink:  ../29847045df67838cd72dc2dfe830a11642fb7153.camel@j-davis.com/
Also on:    postgresql.org/message-id/29847045df67838cd72dc2dfe830a11642fb7153.camel@j-davis.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pgsql@j-davis.com, tgl@sss.pgh.pa.us, pg@bowt.ie, sfrost@snowman.net, alvherre@2ndquadrant.com, andres@anarazel.de, bruce@momjian.us, robertmhaas@gmail.com, dgrowleyml@gmail.com, pryzby@telsasoft.com, melanieplageman@gmail.com, tomas.vondra@2ndquadrant.com
  Subject: Re: Default setting for enable_hashagg_disk
  In-Reply-To: <29847045df67838cd72dc2dfe830a11642fb7153.camel@j-davis.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox