public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Gilles Darold <[email protected]>
Cc: [email protected]
Subject: Re: [Proposal] Allow pg_dump to include all child tables with the root table
Date: Sat, 04 Mar 2023 14:18:13 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<167727895770.12579.12160318039902297475.pgcf@coridan.postgresql.org>
	<CA+gpmf+ciusFs1Ui8cB13HHfuxvhn5Vg+gV3kzHmka_jvQP96Q@mail.gmail.com>
	<[email protected]>

Gilles Darold <[email protected]> writes:
> But I disagree the use of --table-with-childs and 
> --exclude-table-with-childs because we already have the --table and 
> --exclude-table, and it will add lot of code where we just need a switch 
> to include children tables.

I quite dislike the idea of a separate --with-whatever switch, because
it will (presumably) apply to all of your --table and --exclude-table
switches, where you may need it to apply to just some of them.
Spelling considerations aside, attaching the property to the
individual switches seems far superior.  And I neither believe that
this would add a lot of code, nor accept that as an excuse even if
it's true.

As noted, "childs" is bad English and "partitions" is flat out wrong
(unless you change it to recurse only to partitions, which doesn't
seem like a better definition).  We could go with
--[exclude-]table-and-children, or maybe
--[exclude-]table-and-child-tables, but those are getting into
carpal-tunnel-syndrome-inducing territory :-(.  I lack a better
naming suggestion offhand.

			regards, tom lane

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [Proposal] Allow pg_dump to include all child tables with the root table
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox