From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@lists.postgresql.org, John Naylor <john.naylor@enterprisedb.com>
Subject: Re: renumber_oids.pl needs some updates
Date: Wed, 20 Apr 2022 17:10:18 -0400
Message-ID: <2997791.1650489018@sss.pgh.pa.us> (raw)
In-Reply-To: <2eab924a-9667-d287-5e84-a3c54d5f433e@enterprisedb.com>
References: <2995325.1650487527@sss.pgh.pa.us>
<2eab924a-9667-d287-5e84-a3c54d5f433e@enterprisedb.com>
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 20.04.22 22:45, Tom Lane wrote:
>> The attached proposed patch invents a variant macro
>> DECLARE_TOAST_WITH_MACRO for the relatively small number of cases
>> where we need such OID macros.
> This makes sense.
> A more elaborate (future) project would be to have genbki.pl generate
> all of IsSharedRelation(), which is the only place these toast-table-OID
> macros are used, AFAICT.
Perhaps. We invent shared catalogs at a slow enough rate that I'm
not sure the effort would ever pay for itself in person-hours,
but maybe making such invention a trifle less error-prone is
worth something.
I'd still want to keep this form of DECLARE_TOAST, in case someone
comes up with a different reason to want macro names for toast OIDs.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, john.naylor@enterprisedb.com
Subject: Re: renumber_oids.pl needs some updates
In-Reply-To: <2997791.1650489018@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox