From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Kirk Wolak <wolakk@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Jacob Champion <jchampion@timescale.com>
Cc: pgsql-hackers@postgresql.org, gkokolatos@pm.me, Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Dipesh Pandit <dipesh.pandit@gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Subject: Re: zstd compression for pg_dump
Date: Tue, 28 Mar 2023 20:45:33 +0200
Message-ID: <29a12485-944c-bc3b-23d0-2f684609b87f@enterprisedb.com> (raw)
In-Reply-To: <CACLU5mSt7CVTPLEPEjyk0nPxxFxQddO3c=JBrAMN_uUGTN6PfA@mail.gmail.com>
References: <20230224191840.GD1653@telsasoft.com>
<20230226012227.GK1653@telsasoft.com>
<CAAWbhmgEpYPn2sjxr0Kar_XKS4dzyEnussd0emwe2YHxb_tk6g@mail.gmail.com>
<20230303185546.GE12850@telsasoft.com>
<CAAWbhmj-pEhpzfMA+ARnq+L3uS1A1AsmNjz9m_Cx=73n4GRZjQ@mail.gmail.com>
<20230304165747.GH12850@telsasoft.com>
<CAAWbhmgm8yzKLnwK8-Wj-nhYo3R0AvLF6FSX-Pgo=062hGz4JA@mail.gmail.com>
<3d04afca-7d9d-c90f-5fef-5cf4fdb2173f@timescale.com>
<ZBKgBz+4blcKru6x@telsasoft.com>
<0115b682-58f0-ea43-9ecd-c37a4495812e@enterprisedb.com>
<ZCHSSv3DgxUa0f3L@telsasoft.com>
<0022dd9e-a439-d72f-d09b-ec512c23949b@enterprisedb.com>
<CACLU5mSt7CVTPLEPEjyk0nPxxFxQddO3c=JBrAMN_uUGTN6PfA@mail.gmail.com>
On 3/28/23 20:03, Kirk Wolak wrote:
> On Tue, Mar 28, 2023 at 12:23 PM Tomas Vondra
> <tomas.vondra@enterprisedb.com <mailto:tomas.vondra@enterprisedb.com>>
> wrote:
>
> On 3/27/23 19:28, Justin Pryzby wrote:
> > On Fri, Mar 17, 2023 at 03:43:31AM +0100, Tomas Vondra wrote:
> >> On 3/16/23 05:50, Justin Pryzby wrote:
> >>> On Fri, Mar 10, 2023 at 12:48:13PM -0800, Jacob Champion wrote:
> >>>> On Wed, Mar 8, 2023 at 10:59 AM Jacob Champion
> <jchampion@timescale.com <mailto:jchampion@timescale.com>> wrote:
> >>>>> I did some smoke testing against zstd's GitHub release on
> Windows. To
> ...
> OK. I don't have access to a Windows machine so I can't test that. Is it
> possible to disable the zstd threading, until we figure this out?
>
> Thomas since I appear to be one of the few windows users (I use both),
> can I help?
> I can test pg_dump... for you, easy to do. I do about 5-10 pg_dumps a
> day on windows while developing.
>
Perhaps. But I'll leave the details up to Justin - it's his patch, and
I'm not sure how to verify the threading is OK.
I'd try applying this patch, build with --with-zstd and then run the
pg_dump TAP tests, and perhaps do some manual tests.
And perhaps do the same for --with-lz4 - there's a thread [1] suggesting
we don't detect lz4 stuff on Windows, so the TAP tests do nothing.
https://www.postgresql.org/message-id/ZAjL96N9ZW84U59p@msg.df7cb.de> Also, I have an AWS instance I created to build PG/Win with readline
> back in November.
> I could give you access to that... (you are not the only person who has
> made this statement here).
> I've made such instances available for other Open Source developers, to
> support them.
>
> Obvi I would share connection credentials privately.
>
I'd rather leave the Windows stuff up to someone with more experience
with that platform. I have plenty of other stuff on my plate atm.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@enterprisedb.com, wolakk@gmail.com, pryzby@telsasoft.com, jchampion@timescale.com, michael@paquier.xyz, robertmhaas@gmail.com, pg@bowt.ie, peter.eisentraut@enterprisedb.com, hlinnaka@iki.fi, thomas.munro@gmail.com, dipesh.pandit@gmail.com, x4mmm@yandex-team.ru, mark.dilger@enterprisedb.com
Subject: Re: zstd compression for pg_dump
In-Reply-To: <29a12485-944c-bc3b-23d0-2f684609b87f@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox