pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
To: sawada.mshk@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Cc: thomas.munro@enterprisedb.com
Cc: sk@zsrv.org
Cc: michael.paquier@gmail.com
Cc: andres@anarazel.de
Subject: Re: [HACKERS] Restricting maximum keep segments by repslots
Date: Thu, 6 Sep 2018 22:32:21 +0200
Message-ID: <29bbd79d-696b-509e-578a-0fc38a3b9405@2ndquadrant.com> (raw)
In-Reply-To: <20180904.195250.144186960.horiguchi.kyotaro@lab.ntt.co.jp>
References: <CAD21AoD0rChq7wQE=_o95quopcQGjcVG9omwdH07nT5cm81hzg@mail.gmail.com>
	<20180731.181121.32422923.horiguchi.kyotaro@lab.ntt.co.jp>
	<CAD21AoBgCMc9bp2cADMFm40qoEXxbomdu1dtj5EaFSAS4BtAyw@mail.gmail.com>
	<20180904.195250.144186960.horiguchi.kyotaro@lab.ntt.co.jp>

This documentation

+       <para>
+        Specify the maximum size of WAL files
+        that <link linkend="streaming-replication-slots">replication
+        slots</link> are allowed to retain in the
<filename>pg_wal</filename>
+        directory at checkpoint time.
+        If <varname>max_slot_wal_keep_size</varname> is zero (the default),
+        replication slots retain unlimited size of WAL files.
+       </para>

doesn't say anything about what happens when the limit is exceeded.
Does the system halt until the WAL is fetched from the slots?  Do the
slots get invalidated?

Also, I don't think 0 is a good value for the default behavior.  0 would
mean that a slot is not allowed to retain any more WAL than already
exists anyway.  Maybe we don't want to support that directly, but it's a
valid configuration.  So maybe use -1 for infinity.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (143+ messages)  latest in thread

Message-ID: <29bbd79d-696b-509e-578a-0fc38a3b9405@2ndquadrant.com>
Permalink:  ../29bbd79d-696b-509e-578a-0fc38a3b9405@2ndquadrant.com/
Also on:    postgresql.org/message-id/29bbd79d-696b-509e-578a-0fc38a3b9405@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, horiguchi.kyotaro@lab.ntt.co.jp, sawada.mshk@gmail.com, pgsql-hackers@lists.postgresql.org, thomas.munro@enterprisedb.com, sk@zsrv.org, michael.paquier@gmail.com, andres@anarazel.de
  Subject: Re: [HACKERS] Restricting maximum keep segments by repslots
  In-Reply-To: <29bbd79d-696b-509e-578a-0fc38a3b9405@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox