public inbox for [email protected]
help / color / mirror / Atom feedFrom: Chao Li <[email protected]>
To: Bertrand Drouvot <[email protected]>
Cc: [email protected]
Cc: Jeff Davis <[email protected]>
Subject: Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
Date: Fri, 27 Feb 2026 14:04:30 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <aaEhpwrj1FY/8/[email protected]>
References: <aaEhpwrj1FY/8/[email protected]>
> On Feb 27, 2026, at 12:46, Bertrand Drouvot <[email protected]> wrote:
>
> Hi hackers,
>
> Standard practice in PostgreSQL is to use "foo(void)" instead of "foo()", as the
> latter looks like an "old-style" function declaration. 9b05e2ec08a did fix
> all the ones reported by -Wstrict-prototypes.
>
> af2d4ca191a4 introduced a new one, this patch fixes it.
>
> Regards,
>
> --
> Bertrand Drouvot
> PostgreSQL Contributors Team
> RDS Open Source Databases
> Amazon Web Services: https://aws.amazon.com
> <v1-0001-Use-pg_icu_unicode_version-void-instead-of-pg_icu.patch>
This patch is straightforward.
What I'm interested in is the broader policy: when reviewing patches, if we encounter a foo() declaration, should we consistently request a change to foo(void)? If yes, the standard should be documented somewhere.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox