From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Tiny CREATE STATISTICS tab-completion cleanup
Date: Wed, 28 Nov 2018 01:01:15 +0100
Message-ID: <2adf03cf-9a76-311a-2cc0-d0af6aa4bbaa@2ndquadrant.com> (raw)
In-Reply-To: <65551c69-46d4-305e-25fb-2e093454d660@2ndquadrant.com>
References: <d8jwooziy1s.fsf@dalvik.ping.uio.no>
<65551c69-46d4-305e-25fb-2e093454d660@2ndquadrant.com>
On 11/27/18 12:55 AM, Tomas Vondra wrote:
> Hi,
>
> On 11/26/18 5:49 PM, Dagfinn Ilmari Mannsåker wrote:
>> Hi Hackers,
>>
>> As I was hacking on the CREATE TABLE tab completions, I noticed that the
>> CREATE STATISTICS completion was checking manually for the start and end
>> of the parenthesised list instead of using the "(*)" wildcard (because
>> it predates that functionality). Attached is a patch that updates it to
>> use the modern syntax.
>>
>
> Makes sense. At first I was wondering why it was not modified by the
> patch introducing the "(*)" wildcard, but I see 121213d9 only cared
> about VACUUM, EXPLAIN and ANALYZE.
>
> The patch seems fine to me, I'll get it committed.
>
Pushed. Thanks for the patch.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, ilmari@ilmari.org
Subject: Re: [PATCH] Tiny CREATE STATISTICS tab-completion cleanup
In-Reply-To: <2adf03cf-9a76-311a-2cc0-d0af6aa4bbaa@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox