public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Dunstan <[email protected]>
To: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Jelte Fennema <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Noah Misch <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Jesse Zhang <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Thu, 18 May 2023 08:59:28 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com>
	<CAGECzQSUYmfTwEWcVfwb4d=vf=M7RYJjq6ie0YPTUhP+YFcEww@mail.gmail.com>
	<[email protected]>
	<OSZPR01MB63100E1C06045FB66B16728BFDA09@OSZPR01MB6310.jpnprd01.prod.outlook.com>
	<[email protected]>
	<CAGECzQSu6mLzPhd7csBfnXtW9kfoVRn5TWFH1fPGMc4mpkHyOw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAGECzQQH35856o4LsOF5kBAEwna_ONBcarCFcShwbh1yhXAa_w@mail.gmail.com>
	<ef2edec2-e55e-a751-a90f-5929b! [email protected]>
	<[email protected]! gh.pa.us>
	<[email protected]>
	<[email protected]>
	<341b0011-1190-288b! ! [email protected]>
	<[email protected]>
	<[email protected]>


On 2023-05-17 We 17:10, Tom Lane wrote:
> I wrote:
>> Andrew Dunstan<[email protected]>  writes:
>>> I doubt there's something like that.
>> I had a read-through of the latest version's man page, and found
>> this promising-looking entry:
>> 	-boc, --break-at-old-comma-breakpoints
> Sadly, this seems completely not ready for prime time.  I experimented
> with it under perltidy 20230309, and found that it caused hundreds
> of kilobytes of gratuitous changes that don't seem to have a direct
> connection to the claimed purpose.  Most of these seemed to be from
> forcing a line break after a function call's open paren, like
>
> @@ -50,10 +50,12 @@ detects_heap_corruption(
>   #
>   fresh_test_table('test');
>   $node->safe_psql('postgres', q(VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) test));
> -detects_no_corruption("verify_heapam('test')",
> +detects_no_corruption(
> +	"verify_heapam('test')",
>   	"all-frozen not corrupted table");
>   corrupt_first_page('test');
> -detects_heap_corruption("verify_heapam('test')",
> +detects_heap_corruption(
> +	"verify_heapam('test')",
>   	"all-frozen corrupted table");
>   detects_no_corruption(
>   	"verify_heapam('test', skip := 'all-frozen')",
>
> although in some places it just wanted to insert a space, like this:
>
> @@ -77,9 +81,9 @@ print "standby 2: $result\n";
>   is($result, qq(33|0|t), 'check streamed sequence content on standby 2');
>   
>   # Check that only READ-only queries can run on standbys
> -is($node_standby_1->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
> +is( $node_standby_1->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
>   	3, 'read-only queries on standby 1');
> -is($node_standby_2->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
> +is( $node_standby_2->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
>   	3, 'read-only queries on standby 2');
>   
>   # Tests for connection parameter target_session_attrs
>
>
> So I don't think we want that.  Maybe in some future version it'll
> be more under control.
>
> Barring objections, I'll use the attached on Friday.
>
> 			


LGTM


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

view thread (142+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: run pgindent on a regular basis / scripted manner
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox