public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Dunstan <[email protected]>
To: Andres Freund <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: convert libpq uri-regress tests to tap test
Date: Wed, 23 Feb 2022 16:57:02 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>


On 2/23/22 16:16, Andres Freund wrote:
> Hi,
>
> On 2022-02-23 15:57:08 -0500, Tom Lane wrote:
>> Andrew Dunstan <[email protected]> writes:
>>> On 2/23/22 15:30, Andres Freund wrote:
>>>> Perhaps we should just rename src/test/modules/libpq_pipeline to
>>>> src/test/modules/libpq and move uri-regress in there as well?
>>> WFM
>> +1
> Cool.
>
>
> One question on making that happen: Right now the makefiles building C stuff
> in src/test/modules all have the contrib-style stanza to build via pgxs.  But
> afaics pgxs doesn't support building multiple programs. Which
> src/test/modules/libpq would need to.


That's my understanding also.


>
> Aaics there's currently no way to have Mkvcbuild.pm build multiple programs in
> one dir via its makefile parsing stuff? Andrew, any suggestions for not
> needing to spell this out in both the makefile and Mkvcbuild.pm?


Well, it should be a SMOC. If you can solve the first problem I'm sure I
can come up with a solution for Mkvcbuild.pm. But until we see the shape
of the pgxs changes, planning for Mkcvbuild.pm changes seems remature.


>
>
> Separately: I don't really understand why we do the whole if USE_PGXS dance in
> src/test/modules?
>

ENOCLUE


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: convert libpq uri-regress tests to tap test
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox