pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: list of extended statistics on psql
Date: Thu, 7 Jan 2021 00:09:04 +0100
Message-ID: <2fe425ac-dc47-f304-c8d7-9fea763482d7@enterprisedb.com> (raw )
In-Reply-To: <98fc5f3c-3726-a5fd-376f-b29746954b7b@nttcom.co.jp_1 >
References: <20200831153053.a343pjgumahiejhw@development >
<20200831161809.GA31337@alvherre.pgsql >
<20200831163200.jp6eqbaaupb6hxac@development >
<CAFj8pRDsiGozdoeqHC6d8disaY62Zihw5hL3dUHeFaDjyZAxNw@mail.gmail.com >
<d63766ca-19fa-25a6-cb60-e61b6bbc7700@nttcom.co.jp_1 >
<20200917055531.GV2873@paquier.xyz >
<20200930061947.GD1996@paquier.xyz >
<2a3173fb-8571-3779-2916-d16a170750f0@nttcom.co.jp_1 >
<20201028190601.bbshe6dhp32767q7@development >
<027134cc-4c99-2878-4385-c0786283c5ea@nttcom.co.jp_1 >
<831cda41-2299-51f7-12c3-9bf9d3328a58@nttcom.co.jp_1 >
<9ed1643b-5c04-640b-70fa-ad7984972cd0@enterprisedb.com >
<3f695394-9c0a-51d3-9bd7-c25ad2217cca@nttcom.co.jp_1 >
<cba60869-358d-dfc5-7e01-92bd703414fd@nttcom.co.jp_1 >
<1123e0bb-a95e-dd4f-eff5-97a668b48077@enterprisedb.com >
<9ce1985e-2cdc-f56f-fc6b-44d4ef0bcf0d@nttcom.co.jp_1 >
<6505b34d-a6a3-c9e0-9113-ff8dc0127465@nttcom.co.jp_1 >
<98fc5f3c-3726-a5fd-376f-b29746954b7b@nttcom.co.jp_1 >
On 1/5/21 5:26 AM, Tatsuro Yamada wrote:
> Hi,
>
>> I rebased the patch set on the master (7e5e1bba03), and the regression
>> test is good. Therefore, I changed the status of the patch: "needs
>> review".
>
> Happy New Year!
>
> I rebased my patches on HEAD.
> Please find attached files. :-D
>
Thanks, and Happy new year to you too.
I almost pushed this, but I have one more question. listExtendedStats
first checks the server version, and errors out for pre-10 servers.
Shouldn't the logic building query check the server version too, to
decide whether to check the MCV stats? Otherwise it won't work on 10 and
11, which does not support the "mcv" stats.
I don't recall what exactly is our policy regarding new psql with older
server versions, but it seems strange to check for 10.0 and then fail
anyway for "supported" versions.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (75+ messages) latest in thread
Message-ID: <2fe425ac-dc47-f304-c8d7-9fea763482d7@enterprisedb.com>
Permalink: ../2fe425ac-dc47-f304-c8d7-9fea763482d7@enterprisedb.com/
Also on: postgresql.org/message-id/2fe425ac-dc47-f304-c8d7-9fea763482d7@enterprisedb.com
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@enterprisedb.com, tatsuro.yamada.tf@nttcom.co.jp, tomas.vondra@2ndquadrant.com, michael@paquier.xyz, pavel.stehule@gmail.com, alvherre@2ndquadrant.com, rjuju123@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: list of extended statistics on psql
In-Reply-To: <2fe425ac-dc47-f304-c8d7-9fea763482d7@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox