pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jacob Champion <pchampion@vmware.com>
To: michael@paquier.xyz <michael@paquier.xyz>
Cc: sfrost@snowman.net <sfrost@snowman.net>
Cc: rjuju123@gmail.com <rjuju123@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: tgl@sss.pgh.pa.us <tgl@sss.pgh.pa.us>
Cc: andres@anarazel.de <andres@anarazel.de>
Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers
Date: Wed, 6 Apr 2022 19:16:43 +0000
Message-ID: <300712f85a30acecaa5c8f16c968b95537bfebd8.camel@vmware.com> (raw)
In-Reply-To: <Yk108M6LazJT7Vsj@paquier.xyz>
References: <94c53220cb1e8a7a9c411fd14bfc64ff3b65d68d.camel@vmware.com>
	<Yj6wU9DZ7c6MHfTb@paquier.xyz>
	<20220326171550.ywohmkvngh4qc2fo@alap3.anarazel.de>
	<88926.1648317459@sss.pgh.pa.us>
	<20220326183637.eopabpewkhpjyx5k@alap3.anarazel.de>
	<1add3bbf7790214c5a240edbb09b2632e402efb5.camel@vmware.com>
	<20220329235332.z4q5hgv7jsmcavzv@alap3.anarazel.de>
	<214737816b45c29d4aea01ba161f0a2d7876432e.camel@vmware.com>
	<YkveFfb8VAnKUHnM@paquier.xyz>
	<6f7d988668974bb6c0078f6c026b456cd79ae314.camel@vmware.com>
	<Yk108M6LazJT7Vsj@paquier.xyz>

On Wed, 2022-04-06 at 20:09 +0900, Michael Paquier wrote:
> > The current patch already handles NULL with a byte of overhead; is
> > there any advantage to using noError? (It might make things messier
> > once a second member gets added to the struct.) My concern was directed
> > at the GUC proposal.
> 
> FWIW, I am a bit concerned by this approach because it feels
> inconsistent with any other conditional fields passed down from the
> parallel leader to its workers.  And if we need to add more fields to 
> ParallelProcInfo in the future, it will be cleaner to use different
> TOC keys to pass down different fields anyway, no?

I assumed that we would follow the existing model of "(de)serialize a
whole struct", rather than pulling it apart into many separate keys. If
it got too complicated then we could consider introducing a
SerializedParallelProcInfo struct like some of the other functions do.
Maybe that wouldn't work so well if many of the fields are strings?

Is there a significant cost to changing this later, if one approach
turns out to be wrong?

--Jacob


view thread (89+ messages)  latest in thread

Message-ID: <300712f85a30acecaa5c8f16c968b95537bfebd8.camel@vmware.com>
Permalink:  ../300712f85a30acecaa5c8f16c968b95537bfebd8.camel@vmware.com/
Also on:    postgresql.org/message-id/300712f85a30acecaa5c8f16c968b95537bfebd8.camel@vmware.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: pchampion@vmware.com, michael@paquier.xyz, sfrost@snowman.net, rjuju123@gmail.com, tgl@sss.pgh.pa.us, andres@anarazel.de
  Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers
  In-Reply-To: <300712f85a30acecaa5c8f16c968b95537bfebd8.camel@vmware.com>
  References: <94c53220cb1e8a7a9c411fd14bfc64ff3b65d68d.camel@vmware.com> <Yj6wU9DZ7c6MHfTb@paquier.xyz> <20220326171550.ywohmkvngh4qc2fo@alap3.anarazel.de> <88926.1648317459@sss.pgh.pa.us> <20220326183637.eopabpewkhpjyx5k@alap3.anarazel.de> <1add3bbf7790214c5a240edbb09b2632e402efb5.camel@vmware.com> <20220329235332.z4q5hgv7jsmcavzv@alap3.anarazel.de> <214737816b45c29d4aea01ba161f0a2d7876432e.camel@vmware.com> <YkveFfb8VAnKUHnM@paquier.xyz> <6f7d988668974bb6c0078f6c026b456cd79ae314.camel@vmware.com> <Yk108M6LazJT7Vsj@paquier.xyz> <300712f85a30acecaa5c8f16c968b95537bfebd8.camel@vmware.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox